Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct error strings in glusterfs #51084

Merged
merged 1 commit into from Aug 23, 2017
Merged

Correct error strings in glusterfs #51084

merged 1 commit into from Aug 23, 2017

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Aug 22, 2017

Signed-off-by: Humble Chirammal hchiramm@redhat.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 22, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Aug 22, 2017
@humblec
Copy link
Contributor Author

humblec commented Aug 22, 2017

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Aug 22, 2017
@humblec
Copy link
Contributor Author

humblec commented Aug 22, 2017

@k8s-bot ok to test

@humblec
Copy link
Contributor Author

humblec commented Aug 22, 2017

/test pull-kubernetes-e2e-kops-aws

jsafrane
jsafrane reviewed Aug 22, 2017
View reviewed changes
pkg/volume/glusterfs/glusterfs.go
@@ -309,7 +309,7 @@ func (b *glusterfsMounter) setUpAtInternal(dir string) error {

p := path.Join(b.glusterfs.plugin.host.GetPluginDir(glusterfsPluginName), b.glusterfs.volName)
if err := os.MkdirAll(p, 0750); err != nil {
return fmt.Errorf("glusterfs: mkdir failed: %v", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the directory in square brackets?

glusterfs: mkdir [/var/lib/kubelet/plugins/kubernetes.io/glusterfs/xyz] failed: Permission denied.

What about Error creating directory /var/lib/kubelet/plugins/kubernetes.io/glusterfs/xyz: Permission denied?

I don't like glusterfs prefix everywhere too, but that's probably for another PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsafrane Sure.. I think `Error creating..." is better, I will change to that format.

@humblec
Correct error strings in glusterfs
7755286 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
Copy link
Contributor Author

humblec commented Aug 22, 2017

@jsafrane Addressed the comment, Thanks!

@jsafrane
Copy link
Member

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, jsafrane

Associated issue requirement bypassed by: jsafrane

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 50229, 50973, 50976, 51085, 51084)

@k8s-github-robot k8s-github-robot merged commit 7e208be into kubernetes:master Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

Assignees

@pmorie pmorie

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@humblec @jsafrane @k8s-github-robot @pmorie @k8s-ci-robot