Attempt to Attach Volume fails for very first time on vSphere in 1.7 release

[BaluDontu]

Before every attach, vSphere cloud provider checks if the SCSI controller is present on the VM. If not present, it will try to create one and attach the disk to that SCSI controller on VM. If already present, it will use the SCSI controller.

For the very first time when SCSI controller is not present on the VM, we try to create one and retrieve the SCSI controller for the disk to created on that SCSI controller. But in release 1.7, after successful creation of SCSI controller, we are not assigning back the SCSI controller to the existing "scsicontroller" variable. Because of this the very first time, attach of the disk will fail.

This problem is not observed on master, as we have taken care of this in vSphere cloud provider refactoring - #49164

@luomiao @divyenpatel @rohitjogvmw

vSphere: Fix attach volume failing on the first try.

[k8s-ci-robot]

Hi @BaluDontu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[BaluDontu]

@wojtek-t : This is observed only in 1.7 and 1.6 release branches. Can you verify and please approve it.

[divyenpatel]

lgtm

[luomiao]

/lgtm
/approve

[luomiao]

/approve no-issue

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BaluDontu, luomiao

Associated issue requirement bypassed by: luomiao

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/cloudprovider/providers/vsphere/OWNERS [luomiao]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[BaluDontu]

/retest

[k8s-ci-robot]

@BaluDontu: you can't request testing unless you are a kubernetes member.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wojtek-t]

@BaluDontu - please add a (user-friendly) release note to this PR.

[BaluDontu]

/retest

[k8s-ci-robot]

@BaluDontu: you can't request testing unless you are a kubernetes member.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[BaluDontu]

@wojtek-t : I have added the release note. I see needs-ok-test label still on PR. Also can you retry the failed tests.

[wojtek-t]

/retest

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue

[k8s-cherrypick-bot]

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.