-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the status of the terminated containers in the summary endpoint #51610
Remove the status of the terminated containers in the summary endpoint #51610
Conversation
This PR is not for the master branch but does not have the |
Removing label |
/retest |
/lgtm @piosz is this required to fix the bug, or are you going to patch 1.7 with a newer heapster image? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piosz, yujuhong Associated issue: 48739 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
The latter one (see #51620). Kubernetes 1.7 works with nodes in 1.5 and 1.6 which doesn't have the fix, though of course we should merge it as well. |
Given that new heapster with the fix kubernetes-retired/heapster#1790 will be released for 1.7, we don't necessarily need this cherry-pick PR? (Just want to make as few changes as possible for the 1.7 branch.) |
+1 |
This PR is not for the master branch but does not have the |
Agree - there was no fix in Heapster yet while I cherry-picked the PR. |
cherry-pick of #48739
related issue #47853