Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the status of the terminated containers in the summary endpoint #51610

Conversation

piosz
Copy link
Member

@piosz piosz commented Aug 30, 2017

cherry-pick of #48739
related issue #47853

Remove the status of the terminated containers in the Summary API in Kubelet.

@piosz piosz added cherrypick-candidate release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 30, 2017
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 30, 2017
@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Aug 30, 2017
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@yujuhong
Copy link
Contributor

/retest

@yujuhong
Copy link
Contributor

/lgtm

@piosz is this required to fix the bug, or are you going to patch 1.7 with a newer heapster image?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piosz, yujuhong

Associated issue: 48739

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2017
@piosz
Copy link
Member Author

piosz commented Aug 30, 2017

The latter one (see #51620). Kubernetes 1.7 works with nodes in 1.5 and 1.6 which doesn't have the fix, though of course we should merge it as well.

@yguo0905
Copy link
Contributor

Given that new heapster with the fix kubernetes-retired/heapster#1790 will be released for 1.7, we don't necessarily need this cherry-pick PR? (Just want to make as few changes as possible for the 1.7 branch.)

@yujuhong
Copy link
Contributor

Given that new heapster with the fix kubernetes-retired/heapster#1790 will be released for 1.7, we don't necessarily need this cherry-pick PR? (Just want to make as few changes as possible for the 1.7 branch.)

+1
@piosz, I don't think we need to cherry-pick this PR. WDYT?

@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 30, 2017
@piosz
Copy link
Member Author

piosz commented Aug 31, 2017

Agree - there was no fix in Heapster yet while I cherry-picked the PR.

@piosz piosz closed this Aug 31, 2017
@wojtek-t wojtek-t removed cherrypick-candidate do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants