Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the label manifest with new milestone labels #51848

Merged
merged 1 commit into from
Sep 5, 2017

Conversation

xiangpengzhao
Copy link
Contributor

What this PR does / why we need it:
Make the milestone labels more noticeable.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
ref: #51663

Special notes for your reviewer:
/cc @bgrant0607 @fejta
/assign @grodrigues3 @spxtr

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 2, 2017
@k8s-github-robot k8s-github-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 2, 2017
@xiangpengzhao
Copy link
Contributor Author

Have no idea on the test failures... Should the version be v1.8.0 or v1.9.0?

I0902 03:24:59.238] diffing /go/src/k8s.io/kubernetes/federation/apis/openapi-spec against freshly generated federation openapi spec
I0902 03:24:59.244] diff -Naupr -I 'Auto generated by' /go/src/k8s.io/kubernetes/federation/apis/openapi-spec/swagger.json /go/src/k8s.io/kubernetes/_tmp_federation/openapi-spec/swagger.json
I0902 03:24:59.244] --- /go/src/k8s.io/kubernetes/federation/apis/openapi-spec/swagger.json	2017-09-02 03:24:59.202219941 +0000
I0902 03:24:59.244] +++ /go/src/k8s.io/kubernetes/_tmp_federation/openapi-spec/swagger.json	2017-09-02 03:07:44.421511730 +0000
I0902 03:24:59.245] @@ -2,7 +2,7 @@
I0902 03:24:59.245]    "swagger": "2.0",
I0902 03:24:59.245]    "info": {
I0902 03:24:59.245]     "title": "Generic API Server",
I0902 03:24:59.246] -   "version": "v1.9.0"
I0902 03:24:59.246] +   "version": "v1.8.0"
I0902 03:24:59.246]    },
I0902 03:24:59.247]    "paths": {
I0902 03:24:59.247]     "/api/": {
I0902 03:24:59.247] /go/src/k8s.io/kubernetes/federation/apis/openapi-spec is out of date. Please run hack/update-federation-openapi-spec.sh
I0902 03:24:59.257] FAILED   hack/make-rules/../../hack/verify-federation-openapi-spec.sh	188s
I0902 03:46:46.335] diffing /go/src/k8s.io/kubernetes/api/openapi-spec against freshly generated openapi spec
I0902 03:46:46.344] diff -Naupr -I 'Auto generated by' /go/src/k8s.io/kubernetes/api/openapi-spec/swagger.json /go/src/k8s.io/kubernetes/_tmp/openapi-spec/swagger.json
I0902 03:46:46.345] --- /go/src/k8s.io/kubernetes/api/openapi-spec/swagger.json	2017-09-02 03:46:46.311100681 +0000
I0902 03:46:46.345] +++ /go/src/k8s.io/kubernetes/_tmp/openapi-spec/swagger.json	2017-09-02 03:07:44.197511579 +0000
I0902 03:46:46.345] @@ -2,7 +2,7 @@
I0902 03:46:46.345]    "swagger": "2.0",
I0902 03:46:46.345]    "info": {
I0902 03:46:46.346]     "title": "Kubernetes",
I0902 03:46:46.346] -   "version": "v1.9.0"
I0902 03:46:46.346] +   "version": "v1.8.0"
I0902 03:46:46.346]    },
I0902 03:46:46.346]    "paths": {
I0902 03:46:46.346]     "/api/": {
I0902 03:46:46.347] /go/src/k8s.io/kubernetes/api/openapi-spec is out of date. Please run hack/update-openapi-spec.sh
I0902 03:46:46.356] FAILED   hack/make-rules/../../hack/verify-openapi-spec.sh	130s

@xiangpengzhao
Copy link
Contributor Author

/retest

@xiangpengzhao
Copy link
Contributor Author

The pull-kubernetes-verify flake should be fixed by #51851.

@xiangpengzhao
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@xiangpengzhao: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 39244ff link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta
Copy link
Contributor

fejta commented Sep 5, 2017

IMO we should move this file into another repo (kubernetes/test-infra and/or kubernets/repo-infra). Suggesting the idea to sig-contribex on slack

@fejta
Copy link
Contributor

fejta commented Sep 5, 2017

/lgtm
/cc @jdumars @dims

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2017
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They do stand out, let's see how it works! 👍

@jdumars
Copy link
Member

jdumars commented Sep 5, 2017

/lgtm

@bgrant0607
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607, fejta, jdumars, xiangpengzhao

Associated issue: 51663

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2017
@bgrant0607 bgrant0607 added this to the v1.8 milestone Sep 5, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 4b63c1f into kubernetes:master Sep 5, 2017
@xiangpengzhao xiangpengzhao deleted the milestone-label branch September 5, 2017 23:13
@xiangpengzhao
Copy link
Contributor Author

IMO we should move this file into another repo (kubernetes/test-infra and/or kubernets/repo-infra). Suggesting the idea to sig-contribex on slack

@fejta agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants