-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the label manifest with new milestone labels #51848
Update the label manifest with new milestone labels #51848
Conversation
Have no idea on the test failures... Should the version be
|
/retest |
The |
/retest |
@xiangpengzhao: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
IMO we should move this file into another repo (kubernetes/test-infra and/or kubernets/repo-infra). Suggesting the idea to sig-contribex on slack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They do stand out, let's see how it works! 👍
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgrant0607, fejta, jdumars, xiangpengzhao Associated issue: 51663 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue |
@fejta agreed. |
What this PR does / why we need it:
Make the milestone labels more noticeable.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #ref: #51663
Special notes for your reviewer:
/cc @bgrant0607 @fejta
/assign @grodrigues3 @spxtr
Release note: