Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build test targets for all server platforms #51873

Merged
merged 2 commits into from Sep 6, 2017
Merged

Build test targets for all server platforms #51873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b00353c
Build test targets for all server platforms
luxas Sep 3, 2017
64be85e
Fix arm (32-bit) e2e.test compile failure
luxas Sep 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions hack/lib/golang.sh
View file
Open in desktop
Expand Up @@ -112,6 +112,10 @@ else
# Which platforms we should compile test targets for. Not all client platforms need these tests
readonly KUBE_TEST_PLATFORMS=(
linux/amd64
linux/arm
linux/arm64
linux/s390x
linux/ppc64le
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this cause any build performance regressions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this is for release (and the post-ci, independently running kube-cross job) code only. All other jobs etc perform the "fast path" and only build for amd64

darwin/amd64
windows/amd64
)
Expand Down
6 changes: 5 additions & 1 deletion staging/src/k8s.io/apiextensions-apiserver/test/integration/testserver/resources.go
View file
Open in desktop
Expand Up @@ -33,6 +33,10 @@ import (
"k8s.io/client-go/dynamic"
)

const (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change part of this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise arm 32 bit fails due to that the constant is larger than int32 (default on arm) can handle

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

noxuInstanceNum int64 = 9223372036854775807
)

//NewRandomNameCustomResourceDefinition generates a CRD with random name to avoid name conflict in e2e tests
func NewRandomNameCustomResourceDefinition(scope apiextensionsv1beta1.ResourceScope) *apiextensionsv1beta1.CustomResourceDefinition {
// ensure the singular doesn't end in an s for now
Expand Down Expand Up @@ -84,7 +88,7 @@ func NewNoxuInstance(namespace, name string) *unstructured.Unstructured {
"key": "value",
},
"num": map[string]interface{}{
"num1": 9223372036854775807,
"num1": noxuInstanceNum,
"num2": 1000000,
},
},
Expand Down