Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Improve how JobController use queue for backoff #52091

Merged
merged 1 commit into from
Sep 8, 2017
Merged

Bugfix: Improve how JobController use queue for backoff #52091

merged 1 commit into from
Sep 8, 2017

Conversation

clamoriniere1A
Copy link
Contributor

@clamoriniere1A clamoriniere1A commented Sep 7, 2017 •
edited

What this PR does / why we need it:

In some cases, the backoff delay for a given Job is reset unnecessarily.

the PR improves how JobController uses queue for backoff:

  • Centralize the key "forget" and "re-queue" process in only on method.
  • Change the signature of the syncJob method in order to return the
    information if it is necessary to forget the backoff delay for a given
    key.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Links to #51153

Special notes for your reviewer:

Release note:

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 7, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @clamoriniere1A. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 7, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 7, 2017
@soltysh
Copy link
Contributor

soltysh commented Sep 7, 2017

/assign

@soltysh soltysh added this to the v1.8 milestone Sep 7, 2017
@clamoriniere1A
Copy link
Contributor Author

/assign @soltysh

@soltysh
Copy link
Contributor

soltysh commented Sep 7, 2017

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 7, 2017
@soltysh soltysh added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 7, 2017
@soltysh
Copy link
Contributor

soltysh commented Sep 7, 2017

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 7, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2017
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2017
@clamoriniere1A
Improve how JobController use queue for backoff
48116da 
Centralize the key "forget" and "requeue" process in only on method.
Change the signature of the syncJob method in order to return the
information if it is necessary to forget the backoff delay for a given
key.
@clamoriniere1A
Copy link
Contributor Author

/test pull-kubernetes-federation-e2e-gce

@clamoriniere1A
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@soltysh
Copy link
Contributor

soltysh commented Sep 8, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clamoriniere1A, soltysh

Associated issue: 51153

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 52091, 52071)

@k8s-github-robot k8s-github-robot merged commit 26d7284 into kubernetes:master Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@soltysh soltysh

@janetkuo janetkuo

@erictune erictune

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@clamoriniere1A @k8s-ci-robot @soltysh @k8s-github-robot @janetkuo @erictune