Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for labels to "kubectl stop". #5237

Merged
merged 1 commit into from
Mar 11, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/kubectl-delete.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ submits an update to a resource right when you submit a delete, their update
will be lost along with the rest of the resource.
```

kubectl delete ([-f filename] | (<resource> [(<id> | -l <label> | --all)]
kubectl delete (-f filename | <resource> (<id> | -l <label> | --all))

### Examples

Expand Down
7 changes: 6 additions & 1 deletion docs/kubectl-stop.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,17 @@ Attempts to shut down and delete a resource that supports graceful termination.
If the resource is resizable it will be resized to 0 before deletion.
```

kubectl stop (<resource> <id>|-f filename)
kubectl stop (-f filename | <resource> (<id> | -l <label> | --all))

### Examples

```
// Shut down foo.
$ kubectl stop replicationcontroller foo

// Stop pods and services with label name=myLabel.
$ kubectl stop pods,services -l name=myLabel

// Shut down the service defined in service.json
$ kubectl stop -f service.json

Expand All @@ -29,7 +32,9 @@ $ kubectl stop -f path/to/resources
### Options

```
--all=false: [-all] to select all the specified resources
-f, --filename=[]: Filename, directory, or URL to file of resource(s) to be stopped
-l, --selector="": Selector (label query) to filter on
```

### Options inherrited from parent commands
Expand Down
11 changes: 11 additions & 0 deletions docs/man/man1/kubectl-stop.1
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,18 @@ If the resource is resizable it will be resized to 0 before deletion.


.SH OPTIONS
.PP
\fB\-\-all\fP=false
[\-all] to select all the specified resources

.PP
\fB\-f\fP, \fB\-\-filename\fP=[]
Filename, directory, or URL to file of resource(s) to be stopped

.PP
\fB\-l\fP, \fB\-\-selector\fP=""
Selector (label query) to filter on


.SH OPTIONS INHERITED FROM PARENT COMMANDS
.PP
Expand Down Expand Up @@ -140,6 +148,9 @@ If the resource is resizable it will be resized to 0 before deletion.
// Shut down foo.
$ kubectl stop replicationcontroller foo

// Stop pods and services with label name=myLabel.
$ kubectl stop pods,services \-l name=myLabel

// Shut down the service defined in service.json
$ kubectl stop \-f service.json

Expand Down
2 changes: 1 addition & 1 deletion pkg/kubectl/cmd/delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func (f *Factory) NewCmdDelete(out io.Writer) *cobra.Command {
Filenames util.StringList
}{}
cmd := &cobra.Command{
Use: "delete ([-f filename] | (<resource> [(<id> | -l <label> | --all)]",
Use: "delete (-f filename | <resource> (<id> | -l <label> | --all))",
Short: "Delete a resource by filename, stdin, or resource and ID.",
Long: delete_long,
Example: delete_example,
Expand Down
9 changes: 8 additions & 1 deletion pkg/kubectl/cmd/stop.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ If the resource is resizable it will be resized to 0 before deletion.`
stop_example = `// Shut down foo.
$ kubectl stop replicationcontroller foo

// Stop pods and services with label name=myLabel.
$ kubectl stop pods,services -l name=myLabel

// Shut down the service defined in service.json
$ kubectl stop -f service.json

Expand All @@ -46,7 +49,7 @@ func (f *Factory) NewCmdStop(out io.Writer) *cobra.Command {
Filenames util.StringList
}{}
cmd := &cobra.Command{
Use: "stop (<resource> <id>|-f filename)",
Use: "stop (-f filename | <resource> (<id> | -l <label> | --all))",
Short: "Gracefully shut down a resource by id or filename.",
Long: stop_long,
Example: stop_example,
Expand All @@ -59,6 +62,8 @@ func (f *Factory) NewCmdStop(out io.Writer) *cobra.Command {
NamespaceParam(cmdNamespace).RequireNamespace().
ResourceTypeOrNameArgs(false, args...).
FilenameParam(flags.Filenames...).
SelectorParam(cmdutil.GetFlagString(cmd, "selector")).
SelectAllParam(cmdutil.GetFlagBool(cmd, "all")).
Flatten().
Do()
cmdutil.CheckErr(r.Err())
Expand All @@ -76,5 +81,7 @@ func (f *Factory) NewCmdStop(out io.Writer) *cobra.Command {
},
}
cmd.Flags().VarP(&flags.Filenames, "filename", "f", "Filename, directory, or URL to file of resource(s) to be stopped")
cmd.Flags().StringP("selector", "l", "", "Selector (label query) to filter on")
cmd.Flags().Bool("all", false, "[-all] to select all the specified resources")
return cmd
}