Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra steps to delete resource handler trace #52543

Merged
merged 1 commit into from
Sep 15, 2017
Merged

Add extra steps to delete resource handler trace #52543

merged 1 commit into from
Sep 15, 2017

Conversation

shyamjvs
Copy link
Member

Based on #51899 (comment)

cc @kubernetes/sig-scalability-misc @kubernetes/sig-api-machinery-misc @gmarek

@shyamjvs shyamjvs added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 15, 2017
@shyamjvs shyamjvs added this to the v1.8 milestone Sep 15, 2017
@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 15, 2017
wojtek-t
wojtek-t reviewed Sep 15, 2017
View reviewed changes
staging/src/k8s.io/apiserver/pkg/endpoints/handlers/rest.go Outdated
@@ -949,6 +949,7 @@ func DeleteResource(r rest.GracefulDeleter, allowsOptions bool, scope RequestSco
scope.err(err, w, req)
return
}
trace.Step("Read DeleteOptions body")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete it - it's not useful.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@shyamjvs shyamjvs force-pushed the add-more-traces-to-delete-resource-handler branch from 4465433 to 6089cad Compare September 15, 2017 14:12
@wojtek-t
Copy link
Member

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shyamjvs, wojtek-t

Associated issue: 51899

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2017
@jdumars
Copy link
Member

jdumars commented Sep 15, 2017

/test pull-kubernetes-e2e-gce-bazel

@k8s-ci-robot
Copy link
Contributor

@shyamjvs: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-bazel 6089cad link /test pull-kubernetes-e2e-gce-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 9f954c1 into kubernetes:master Sep 15, 2017
@shyamjvs shyamjvs deleted the add-more-traces-to-delete-resource-handler branch September 15, 2017 15:30
@shyamjvs shyamjvs mentioned this pull request Sep 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shyamjvs @wojtek-t @k8s-github-robot @jdumars @k8s-ci-robot