Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #50012 #52545

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Automated cherry pick of #50012 #52545

merged 1 commit into from
Oct 2, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Sep 15, 2017 •
edited
Loading

Cherry pick of #50012 on release-1.7.

#50012: use specified discovery information if possible

custom resources that use unconventional pluralization now work properly with kubectl

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 15, 2017
@liggitt liggitt mentioned this pull request Sep 15, 2017
Merged
@liggitt liggitt added kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Sep 15, 2017
@liggitt liggitt added this to the v1.7 milestone Sep 15, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Sep 15, 2017
@liggitt
Copy link
Member Author

liggitt commented Sep 16, 2017

/retest

1 similar comment
@liggitt
Copy link
Member Author

liggitt commented Sep 16, 2017

/retest

@gmarek
Copy link
Contributor

gmarek commented Sep 18, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmarek, liggitt

Associated issue: 50012

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@lavalamp
Copy link
Member

@wojtek-t You're the 1.7 branch manager? Please take this patch :)

@gmarek
Copy link
Contributor

gmarek commented Sep 19, 2017

@lavalamp - @wojtek-t is OOO this week.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@liggitt
Copy link
Member Author

liggitt commented Sep 25, 2017

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@liggitt
Copy link
Member Author

liggitt commented Sep 30, 2017

/retest

2 similar comments
@liggitt
Copy link
Member Author

liggitt commented Oct 1, 2017

/retest

@liggitt
Copy link
Member Author

liggitt commented Oct 2, 2017

/retest

@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 2, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit dd388c7 into kubernetes:release-1.7 Oct 2, 2017
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@k8s-ci-robot
Copy link
Contributor

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-bazel dc55e3f link /test pull-kubernetes-e2e-gce-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nikhita nikhita mentioned this pull request Oct 4, 2017
Closed
@liggitt liggitt deleted the automated-cherry-pick-of-#50012-upstream-release-1.7 branch February 15, 2019 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmarek gmarek

@luxas luxas

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@liggitt @gmarek @k8s-github-robot @lavalamp @fejta-bot @k8s-cherrypick-bot @k8s-ci-robot @luxas @wojtek-t @deads2k