Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include audit log in master log capture #52960

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Include audit log in master log capture #52960

merged 1 commit into from
Sep 25, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Sep 25, 2017

No description provided.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 25, 2017
@liggitt liggitt mentioned this pull request Sep 25, 2017
Closed
@liggitt liggitt added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 25, 2017
@liggitt liggitt assigned shyamjvs and tallclair and unassigned jbeda and eparis Sep 25, 2017
@dims
Copy link
Member

dims commented Sep 25, 2017

LGTM 👍

@liggitt
Copy link
Member Author

liggitt commented Sep 25, 2017

/retest

@eparis
Copy link
Contributor

eparis commented Sep 25, 2017

/approve no-issue

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2017
@liggitt liggitt added this to the v1.9 milestone Sep 25, 2017
@shyamjvs
Copy link
Member

/lgtm
I think it'd add ~15GB of extra gcs storage (per 5k perf-test run) iirc from what I saw earlier - but worth giving a shot.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2017
@liggitt
Copy link
Member Author

liggitt commented Sep 25, 2017

I think it'd add ~15GB of extra gcs storage (per 5k perf-test run) iirc from what I saw earlier - but worth giving a shot.

can surface maxsize/maxbackup settings and tune them down for that job if needed

@liggitt liggitt mentioned this pull request Sep 25, 2017
Merged
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@shyamjvs
Copy link
Member

SGTM. Can we close this with #52998?

@shyamjvs
Copy link
Member

Maybe let's just let this be, as it's close to being merged.

@tallclair
Copy link
Member

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, liggitt, shyamjvs, tallclair

Associated issue requirement bypassed by: eparis

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here..

@k8s-github-robot k8s-github-robot merged commit 4714cdd into kubernetes:master Sep 25, 2017
@liggitt liggitt deleted the gather-audit-log branch September 25, 2017 19:49
k8s-github-robot pushed a commit that referenced this pull request Sep 26, 2017
Merge pull request #52998 from liggitt/audit-scale
bafe4fb 
Automatic merge from submit-queue (batch tested with PRs 52721, 53057, 52493, 52998, 52896). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Adjust audit policy to omit high-volume or large responses from expected actors

Builds on #52960

Possibly related to density test failures #51899 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shyamjvs shyamjvs

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@liggitt @dims @eparis @shyamjvs @k8s-github-robot @tallclair @jbeda @k8s-ci-robot