Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct APIGroup for RoleBindingBuilder Subjects #53239

Merged

Commits on Sep 30, 2017

  1. Correct APIGroup for RoleBindingBuilder Subjects

    This change corrects RoleBindingBuilder to use the RBAC API group
    with users and groups as subjects (service accounts use the empty
    string since they are in the legacy core group).  This is based on
    the defaulting in pkg/apis/rbac/v1/defaults.go#SetDefaults_Subject.
    This is required because the bootstrap RBAC data is built with these
    helpers and does not go through defaulting, whereas the data
    retrieved from the server has already gone through defaulting.  This
    can lead to the reconciliation code incorrectly adding duplicate
    subjects because it believes that they are missing (since the API
    groups do not match).
    
    Signed-off-by: Monis Khan <mkhan@redhat.com>
    enj committed Sep 30, 2017
    Configuration menu
    Copy the full SHA
    5eb5b3e View commit details
    Browse the repository at this point in the history