Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove status option when do nova list #53855

Closed
wants to merge 1 commit into from
Closed

remove status option when do nova list #53855

wants to merge 1 commit into from

Conversation

wenlxie
Copy link
Contributor

@wenlxie wenlxie commented Oct 13, 2017

We use openstack as a cloud provider.
The node maybe at SHUTOFF or ERROR status when the hypervisor down or node has issues. Then the node controller will delete this node from k8s because its status is not ACTIVE in the cloud.
But the volume may still attached to the node, and k8s attach_detach_controller will not detach these volumes because of the node had been deleted.

We are using k8s1.6.

@anguslees @dims @gnufied @jingxu97

@k8s-ci-robot
Copy link
Contributor

@wenlxie: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @wenlxie. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 13, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wenlxie
We suggest the following additional approver: anguslees

Assign the PR to them by writing /assign @anguslees in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@dims
Copy link
Member

dims commented Oct 13, 2017

/assign @anguslees

@dims
Copy link
Member

dims commented Oct 13, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 13, 2017
@dims
Copy link
Member

dims commented Oct 13, 2017

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 13, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 13, 2017

@wenlxie: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-verify 5af58ce link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@huzhengchuan
Copy link
Contributor

cc @huzhengchuan

@jingxu97
Copy link
Contributor

@wenlxie after node is deleted, pods will be garbaged collected (killed). So attach_detach controller should detach the volume after pod object is deleted. Please let me know if you see difference in your testing environment. Thanks!

@k8s-github-robot
Copy link

This PR hasn't been active in 30 days. It will be closed in 59 days (Jan 11, 2018).

cc @anguslees @dims @wenlxie

You can add 'keep-open' label to prevent this from happening, or add a comment to keep it open another 90 days

@dims
Copy link
Member

dims commented Nov 22, 2017

/close

please reopen if necessary

@wenlxie
Copy link
Contributor Author

wenlxie commented Jan 10, 2018

issues related: #57497

@wenlxie wenlxie deleted the githubupstream.master.removestatusoption branch October 24, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants