Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PodDisruptionBudget to scheduler cache. #53914

Merged
merged 2 commits into from
Oct 23, 2017
Merged

Add PodDisruptionBudget to scheduler cache. #53914

merged 2 commits into from
Oct 23, 2017

Conversation

bsalamat
Copy link
Member

What this PR does / why we need it:
This is the first step to add support for PodDisruptionBudget during preemption. This PR adds PDB to scheduler cache.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer: None

Release note:

Add PodDisruptionBudget to scheduler cache.

ref/ #53913

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 13, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2017
@bsalamat
Copy link
Member Author

@k82cn If you'd like to work on adding support for PDB to preemption, you may want to send a follow-up PR that checks PDB during preemption and node scoring.

@k82cn
Copy link
Member

k82cn commented Oct 14, 2017

sure, I'll handle PDB part for preemption.

resouer
resouer reviewed Oct 14, 2017
View reviewed changes
plugin/pkg/scheduler/factory/factory.go Outdated
@@ -605,6 +621,56 @@ func (c *ConfigFactory) deleteNodeFromCache(obj interface{}) {
}
}

func (c *ConfigFactory) addPDBToCache(obj interface{}) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's configFactory. Seems you need a rebase of latest change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Just fixed it.

@k8s-github-robot k8s-github-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2017
@bsalamat
Copy link
Member Author

@k82cn @resouer I fixed the RBAC rules which were causing tests to fail. PTAL.

@k82cn
Copy link
Member

k82cn commented Oct 18, 2017

LGTM :).

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2017
@k82cn
Copy link
Member

k82cn commented Oct 19, 2017

/retest

2 similar comments
@bsalamat
Copy link
Member Author

/retest

@bsalamat
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 21, 2017 •
edited
Loading

@bsalamat: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-etcd3 6ae3c3dbd2abebf976dc11425e5dc2deb58a4a5a link /test pull-kubernetes-e2e-gce-etcd3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bsalamat
Copy link
Member Author

@k82cn I had to fix scheduler_perf/util.go and add the new parameter for scheduler initialization. Could you please take another look?

@k82cn
Copy link
Member

k82cn commented Oct 22, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2017
@bsalamat
Copy link
Member Author

@liggitt for approval of the changes in auth. Thanks!

@liggitt
Copy link
Member

liggitt commented Oct 23, 2017

/approve
policy changes LGTM

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, k82cn, liggitt

Associated issue: 53913

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 53903, 53914, 54374). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 6a44467 into kubernetes:master Oct 23, 2017
@bsalamat bsalamat deleted the pdb branch October 23, 2017 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resouer resouer resouer left review comments

Assignees

@jayunit100 jayunit100

@resouer resouer

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bsalamat @k82cn @k8s-ci-robot @liggitt @k8s-github-robot @resouer @jayunit100