Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #53527 #53986

Merged
merged 1 commit into from Nov 2, 2017
Merged

Automated cherry pick of #53527 #53986

merged 1 commit into from Nov 2, 2017

Conversation

kawych
Copy link
Contributor

@kawych kawych commented Oct 16, 2017 •
edited

Cherry pick of #53527 on release-1.8.

#53527: Autoscaler metrics-server with pod-nanny

Autoscale Metrics Server with pod-nanny

@k8s-ci-robot
Copy link
Contributor

@kawych: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #53527.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@kawych: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 16, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 16, 2017
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 16, 2017
@kawych
Copy link
Contributor Author

kawych commented Oct 16, 2017

/unassign @piosz
/unassign @DirectXMan12
/assign @crassirostris
/assign @jpbetz

@crassirostris
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: crassirostris, kawych
We suggest the following additional approver: piosz

Assign the PR to them by writing /assign @piosz in a comment when ready.

Associated issue: 53527

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@kawych
Copy link
Contributor Author

kawych commented Oct 17, 2017

/retest

@jpbetz jpbetz added this to the v1.8 milestone Oct 17, 2017
@kawych
Copy link
Contributor Author

kawych commented Oct 18, 2017

/assign @DirectXMan12

@jpbetz jpbetz added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 20, 2017
@k8s-github-robot k8s-github-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 20, 2017
@jpbetz jpbetz removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 23, 2017
@jpbetz
Copy link
Contributor

jpbetz commented Oct 23, 2017

We are starting 1.8.2 code freeze. Removing cherrypick-approved label temporarily on all PRs that are not yet ready to merge either due to missing approvals or failing tests. This label will be added back to this PR after 1.8.2 is released. See Release Cut for process details.

@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 23, 2017
@kawych
Copy link
Contributor Author

kawych commented Oct 24, 2017

/unassign @DirectXMan12

@jpbetz jpbetz added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 25, 2017
@k8s-github-robot k8s-github-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 25, 2017
@jpbetz jpbetz added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2017
@kawych kawych closed this Nov 2, 2017
@kawych kawych reopened this Nov 2, 2017
@kawych
Copy link
Contributor Author

kawych commented Nov 2, 2017

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit d7f4086 into kubernetes:release-1.8 Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jpbetz jpbetz

@crassirostris crassirostris

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kawych @k8s-ci-robot @crassirostris @k8s-github-robot @jpbetz @DirectXMan12 @piosz