E2E scale test for vSphere Cloud Provider Volume lifecycle operations #54018
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,247 @@ | ||
| /* | ||
| Copyright 2017 The Kubernetes Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package storage | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "os" | ||
| "strconv" | ||
|
|
||
| . "github.com/onsi/ginkgo" | ||
| . "github.com/onsi/gomega" | ||
| "k8s.io/api/core/v1" | ||
| storageV1 "k8s.io/api/storage/v1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| k8stypes "k8s.io/apimachinery/pkg/types" | ||
| clientset "k8s.io/client-go/kubernetes" | ||
| "k8s.io/kubernetes/pkg/cloudprovider/providers/vsphere" | ||
| "k8s.io/kubernetes/test/e2e/framework" | ||
| ) | ||
|
|
||
| /* | ||
| Perform vsphere volume life cycle management at scale based on user configurable value for number of volumes. | ||
| The following actions will be performed as part of this test. | ||
|
|
||
| 1. Create Storage Classes of 4 Categories (Default, SC with Non Default Datastore, SC with SPBM Policy, SC with VSAN Storage Capalibilies.) | ||
| 2. Read VCP_SCALE_VOLUME_COUNT, VCP_SCALE_INSTANCES, VCP_SCALE_VOLUMES_PER_POD, VSPHERE_SPBM_POLICY_NAME, VSPHERE_DATASTORE from System Environment. | ||
| 3. Launch VCP_SCALE_INSTANCES goroutine for creating VCP_SCALE_VOLUME_COUNT volumes. Each goroutine is responsible for create/attach of VCP_SCALE_VOLUME_COUNT/VCP_SCALE_INSTANCES volumes. | ||
| 4. Read VCP_SCALE_VOLUMES_PER_POD from System Environment. Each pod will be have VCP_SCALE_VOLUMES_PER_POD attached to it. | ||
| 5. Once all the go routines are completed, we delete all the pods and volumes. | ||
| */ | ||
| const ( | ||
| NodeLabelKey = "vsphere_e2e_label" | ||
| ) | ||
|
|
||
| // NodeSelector holds | ||
| type NodeSelector struct { | ||
| labelKey string | ||
| labelValue string | ||
| } | ||
|
|
||
| var _ = SIGDescribe("vcp at scale [Feature:vsphere] ", func() { | ||
| f := framework.NewDefaultFramework("vcp-at-scale") | ||
|
|
||
| var ( | ||
| client clientset.Interface | ||
| namespace string | ||
| nodeSelectorList []*NodeSelector | ||
| volumeCount int | ||
| numberOfInstances int | ||
| volumesPerPod int | ||
| nodeVolumeMapChan chan map[string][]string | ||
| nodes *v1.NodeList | ||
| policyName string | ||
| datastoreName string | ||
| scNames = []string{storageclass1, storageclass2, storageclass3, storageclass4} | ||
| err error | ||
| ) | ||
|
|
||
| BeforeEach(func() { | ||
| framework.SkipUnlessProviderIs("vsphere") | ||
| client = f.ClientSet | ||
| namespace = f.Namespace.Name | ||
| nodeVolumeMapChan = make(chan map[string][]string) | ||
|
|
||
| // Read the environment variables | ||
| volumeCountStr := os.Getenv("VCP_SCALE_VOLUME_COUNT") | ||
| Expect(volumeCountStr).NotTo(BeEmpty(), "ENV VCP_SCALE_VOLUME_COUNT is not set") | ||
| volumeCount, err = strconv.Atoi(volumeCountStr) | ||
| Expect(err).NotTo(HaveOccurred(), "Error Parsing VCP_SCALE_VOLUME_COUNT") | ||
|
|
||
| volumesPerPodStr := os.Getenv("VCP_SCALE_VOLUME_PER_POD") | ||
| Expect(volumesPerPodStr).NotTo(BeEmpty(), "ENV VCP_SCALE_VOLUME_PER_POD is not set") | ||
| volumesPerPod, err = strconv.Atoi(volumesPerPodStr) | ||
| Expect(err).NotTo(HaveOccurred(), "Error Parsing VCP_SCALE_VOLUME_PER_POD") | ||
|
|
||
| numberOfInstancesStr := os.Getenv("VCP_SCALE_INSTANCES") | ||
| Expect(numberOfInstancesStr).NotTo(BeEmpty(), "ENV VCP_SCALE_INSTANCES is not set") | ||
| numberOfInstances, err = strconv.Atoi(numberOfInstancesStr) | ||
| Expect(err).NotTo(HaveOccurred(), "Error Parsing VCP_SCALE_INSTANCES") | ||
| Expect(numberOfInstances > 5).NotTo(BeTrue(), "Maximum allowed instances are 5") | ||
| Expect(numberOfInstances > volumeCount).NotTo(BeTrue(), "Number of instances should be less than the total volume count") | ||
|
There was a problem hiding this comment. "less than or equal to" based on the condition. There was a problem hiding this comment. volumeCount is not validated to be within a required range, thus, this test for numberOfInstances is not reliable. In general, user input should be validated to prevent test flakes. It is ok with me if validating these env var inputs is addressed across all vshpere tests in a separate pr. |
||
|
|
||
| policyName = os.Getenv("VSPHERE_SPBM_POLICY_NAME") | ||
| datastoreName = os.Getenv("VSPHERE_DATASTORE") | ||
| Expect(policyName).NotTo(BeEmpty(), "ENV VSPHERE_SPBM_POLICY_NAME is not set") | ||
| Expect(datastoreName).NotTo(BeEmpty(), "ENV VSPHERE_DATASTORE is not set") | ||
|
|
||
| nodes = framework.GetReadySchedulableNodesOrDie(client) | ||
| if len(nodes.Items) < 2 { | ||
| framework.Skipf("Requires at least %d nodes (not %d)", 2, len(nodes.Items)) | ||
|
|
||
| } | ||
| // Verify volume count specified by the user can be satisfied | ||
| if volumeCount > volumesPerNode*len(nodes.Items) { | ||
| framework.Skipf("Cannot attach %d volumes to %d nodes. Maximum volumes that can be attached on %d nodes is %d", volumeCount, len(nodes.Items), len(nodes.Items), volumesPerNode*len(nodes.Items)) | ||
| } | ||
| nodeSelectorList = createNodeLabels(client, namespace, nodes) | ||
| }) | ||
|
|
||
| /* | ||
| Remove labels from all the nodes | ||
| */ | ||
| framework.AddCleanupAction(func() { | ||
| for _, node := range nodes.Items { | ||
| framework.RemoveLabelOffNode(client, node.Name, NodeLabelKey) | ||
| } | ||
| }) | ||
|
|
||
| It("vsphere scale tests", func() { | ||
| var pvcClaimList []string | ||
| nodeVolumeMap := make(map[k8stypes.NodeName][]string) | ||
| // Volumes will be provisioned with each different types of Storage Class | ||
| scArrays := make([]*storageV1.StorageClass, len(scNames)) | ||
| for index, scname := range scNames { | ||
| // Create vSphere Storage Class | ||
| By(fmt.Sprintf("Creating Storage Class : %q", scname)) | ||
| var sc *storageV1.StorageClass | ||
| scParams := make(map[string]string) | ||
| var err error | ||
| switch scname { | ||
| case storageclass1: | ||
| scParams = nil | ||
| case storageclass2: | ||
| scParams[Policy_HostFailuresToTolerate] = "1" | ||
| case storageclass3: | ||
| scParams[SpbmStoragePolicy] = policyName | ||
| case storageclass4: | ||
| scParams[Datastore] = datastoreName | ||
| } | ||
| sc, err = client.StorageV1().StorageClasses().Create(getVSphereStorageClassSpec(scname, scParams)) | ||
| Expect(sc).NotTo(BeNil(), "Storage class is empty") | ||
| Expect(err).NotTo(HaveOccurred(), "Failed to create storage class") | ||
| defer client.StorageV1().StorageClasses().Delete(scname, nil) | ||
| scArrays[index] = sc | ||
| } | ||
|
|
||
| vsp, err := vsphere.GetVSphere() | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| volumeCountPerInstance := volumeCount / numberOfInstances | ||
|
There was a problem hiding this comment. where is the sanity checking on |
||
| for instanceCount := 0; instanceCount < numberOfInstances; instanceCount++ { | ||
| if instanceCount == numberOfInstances-1 { | ||
| volumeCountPerInstance = volumeCount | ||
| } | ||
| volumeCount = volumeCount - volumeCountPerInstance | ||
| go VolumeCreateAndAttach(client, namespace, scArrays, volumeCountPerInstance, volumesPerPod, nodeSelectorList, nodeVolumeMapChan, vsp) | ||
| } | ||
|
|
||
| // Get the list of all volumes attached to each node from the go routines by reading the data from the channel | ||
| for instanceCount := 0; instanceCount < numberOfInstances; instanceCount++ { | ||
| for node, volumeList := range <-nodeVolumeMapChan { | ||
|
There was a problem hiding this comment. doesn't this channel need to be explicitly closed to end the loop? There was a problem hiding this comment. You needn't close every channel when you've finished with it. It's only necessary to close a channel when it is important to tell the receiving go routines that all data have been sent. A channel that the garbage collector determines to be unreachable will have its resources reclaimed whether or not it is closed. However just to not end up consuming more resources, I have explicitly closed the channel. |
||
| nodeVolumeMap[k8stypes.NodeName(node)] = append(nodeVolumeMap[k8stypes.NodeName(node)], volumeList...) | ||
| } | ||
| } | ||
| podList, err := client.CoreV1().Pods(namespace).List(metav1.ListOptions{}) | ||
| for _, pod := range podList.Items { | ||
| pvcClaimList = append(pvcClaimList, getClaimsForPod(&pod, volumesPerPod)...) | ||
| By("Deleting pod") | ||
| err = framework.DeletePodWithWait(f, client, &pod) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| } | ||
| By("Waiting for volumes to be detached from the node") | ||
| err = waitForVSphereDisksToDetach(vsp, nodeVolumeMap) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| for _, pvcClaim := range pvcClaimList { | ||
| err = framework.DeletePersistentVolumeClaim(client, pvcClaim, namespace) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| } | ||
| }) | ||
| }) | ||
|
|
||
| // Get PVC claims for the pod | ||
| func getClaimsForPod(pod *v1.Pod, volumesPerPod int) []string { | ||
| pvcClaimList := make([]string, volumesPerPod) | ||
| for i, volumespec := range pod.Spec.Volumes { | ||
| if volumespec.PersistentVolumeClaim != nil { | ||
| pvcClaimList[i] = volumespec.PersistentVolumeClaim.ClaimName | ||
| } | ||
| } | ||
| return pvcClaimList | ||
| } | ||
|
|
||
| // VolumeCreateAndAttach peforms create and attach operations of vSphere persistent volumes at scale | ||
| func VolumeCreateAndAttach(client clientset.Interface, namespace string, sc []*storageV1.StorageClass, volumeCountPerInstance int, volumesPerPod int, nodeSelectorList []*NodeSelector, nodeVolumeMapChan chan map[string][]string, vsp *vsphere.VSphere) { | ||
| defer GinkgoRecover() | ||
| nodeVolumeMap := make(map[string][]string) | ||
| nodeSelectorIndex := 0 | ||
| for index := 0; index < volumeCountPerInstance; index = index + volumesPerPod { | ||
| if (volumeCountPerInstance - index) < volumesPerPod { | ||
| volumesPerPod = volumeCountPerInstance - index | ||
| } | ||
| pvclaims := make([]*v1.PersistentVolumeClaim, volumesPerPod) | ||
| for i := 0; i < volumesPerPod; i++ { | ||
| By("Creating PVC using the Storage Class") | ||
| pvclaim, err := framework.CreatePVC(client, namespace, getVSphereClaimSpecWithStorageClassAnnotation(namespace, "2Gi", sc[index%len(sc)])) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| pvclaims[i] = pvclaim | ||
| } | ||
|
|
||
| By("Waiting for claim to be in bound phase") | ||
| persistentvolumes, err := framework.WaitForPVClaimBoundPhase(client, pvclaims, framework.ClaimProvisionTimeout) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| By("Creating pod to attach PV to the node") | ||
| nodeSelector := nodeSelectorList[nodeSelectorIndex%len(nodeSelectorList)] | ||
| // Create pod to attach Volume to Node | ||
| pod, err := framework.CreatePod(client, namespace, map[string]string{nodeSelector.labelKey: nodeSelector.labelValue}, pvclaims, false, "") | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| for _, pv := range persistentvolumes { | ||
| nodeVolumeMap[pod.Spec.NodeName] = append(nodeVolumeMap[pod.Spec.NodeName], pv.Spec.VsphereVolume.VolumePath) | ||
| } | ||
| By("Verify the volume is accessible and available in the pod") | ||
| verifyVSphereVolumesAccessible(pod, persistentvolumes, vsp) | ||
| nodeSelectorIndex++ | ||
| } | ||
| nodeVolumeMapChan <- nodeVolumeMap | ||
| close(nodeVolumeMapChan) | ||
| } | ||
|
|
||
| func createNodeLabels(client clientset.Interface, namespace string, nodes *v1.NodeList) []*NodeSelector { | ||
| var nodeSelectorList []*NodeSelector | ||
| for i, node := range nodes.Items { | ||
| labelVal := "vsphere_e2e_" + strconv.Itoa(i) | ||
| nodeSelector := &NodeSelector{ | ||
| labelKey: NodeLabelKey, | ||
| labelValue: labelVal, | ||
| } | ||
| nodeSelectorList = append(nodeSelectorList, nodeSelector) | ||
| framework.AddOrUpdateLabelOnNode(client, node.Name, NodeLabelKey, labelVal) | ||
| } | ||
| return nodeSelectorList | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice addition