exit with correct exit code on plugin failure

[juanvallejo]

Release note:

NONE

Correctly exits after a plugin command execution failure with the correct exit code.
Related downstream bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1501756

Before

$ kubectl plugin will-fail-plugin
ls: cannot access 'does-not-exist': No such file or directory
error: exit status 2

$ echo $?
1

After

$ kubectl plugin will-fail-plugin
ls: cannot access 'does-not-exist': No such file or directory
error: exit status 2

$ echo $?
2

cc @fabianofranz

[k8s-ci-robot]

Hi @juanvallejo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fabianofranz]

/ok-to-test

[fabianofranz]

/assign

[fabianofranz]

Hrm, need to check if this works on Mac and Windows.

[juanvallejo]

Sure, will go ahead and test this on both

[juanvallejo]

Seems to work as expected on Windows:

Will test on mac tomorrow and post screenshot for it.

[juanvallejo]

@fabianofranz works as expected on mac:

@sg00dwin thanks for helping me test on mac

[juanvallejo]

/test pull-kubernetes-unit

[fabianofranz]

/lgtm
/approve https://bugzilla.redhat.com/show_bug.cgi?id=1501756
/sig cli

[k8s-github-robot]

/test all

Tests are more than 96 hours old. Re-running tests.

[fabianofranz]

/approve no-issue

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianofranz, juanvallejo

Associated issue requirement bypassed by: fabianofranz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/kubectl/OWNERS [fabianofranz]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 54107, 54184, 54377, 54094, 54111). If you want to cherry-pick this change to another branch, please follow the instructions here.