-
Notifications
You must be signed in to change notification settings - Fork 39.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure network policy conversion round trips nil from fields #54106
Ensure network policy conversion round trips nil from fields #54106
Conversation
@liggitt: Adding do-not-merge/release-note-label-needed because the release note process has not been followed. One of the following labels is required "release-note", "release-note-action-required", or "release-note-none". Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5e07827
to
04be59c
Compare
cc @kubernetes/sig-network-api-reviews @kubernetes/sig-network-pr-reviews |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cmluciano, liggitt Associated issue: 53906 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
ping @wojtek-t for cherrypick approval |
@liggitt - sorry for the delay. I don't know why, but I though it's a PR to the master branch and waited for it to be merged before cherrypicking to 1.7. Apparently it's not the case. Yes - the cherrypick is reasonable. Approved. |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
Fixes #53906 (inability to apply network policies against v1 in 1.7)
nil
and produced an output of[]