New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update created-by annotation details #54951
Conversation
The annotation has been removed.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: crimsonfaith91 Assign the PR to them by writing No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@liggitt I updated the change log accordingly. Pinging you for review. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be done in 1.9 change log, instead of 1.8.
And not made directly, gathered by release tool from description of the PR that made the change |
@janetkuo @liggitt Thanks for clarifying! It looks weird to me too to change 1.8 log for a modification targeting 1.9 release, but I thought I was asked to modify 1.8 log from this comment: #54445 (comment) I didn't know existence of the release tool. |
What @liggitt meant was the release-note block in the PR description. It'll be parsed by release tool to generate changelogs (done by release team). |
@janetkuo i see! thanks! |
What this PR does / why we need it:
This PR removes created-by annotation item from the deprecation section and indicates that it has been removed in 1.9 release.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
1.9 release is not rolled out yet. This is an early modification to the change log.
Release note: