Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update created-by annotation details #54951

Closed
wants to merge 1 commit into from

Conversation

crimsonfaith91
Copy link
Contributor

@crimsonfaith91 crimsonfaith91 commented Nov 1, 2017

What this PR does / why we need it:
This PR removes created-by annotation item from the deprecation section and indicates that it has been removed in 1.9 release.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
1.9 release is not rolled out yet. This is an early modification to the change log.

Release note:

NONE

The annotation has been removed.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 1, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: crimsonfaith91
We suggest the following additional approver: smarterclayton

Assign the PR to them by writing /assign @smarterclayton in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@crimsonfaith91
Copy link
Contributor Author

@liggitt I updated the change log accordingly. Pinging you for review. :)

Copy link
Member

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done in 1.9 change log, instead of 1.8.

@liggitt
Copy link
Member

liggitt commented Nov 2, 2017

And not made directly, gathered by release tool from description of the PR that made the change

@liggitt liggitt closed this Nov 2, 2017
@crimsonfaith91
Copy link
Contributor Author

crimsonfaith91 commented Nov 2, 2017

@janetkuo @liggitt Thanks for clarifying! It looks weird to me too to change 1.8 log for a modification targeting 1.9 release, but I thought I was asked to modify 1.8 log from this comment: #54445 (comment)

I didn't know existence of the release tool.

@janetkuo
Copy link
Member

janetkuo commented Nov 3, 2017

I thought I was asked to modify 1.8 log from this comment: #54445 (comment)

What @liggitt meant was the release-note block in the PR description. It'll be parsed by release tool to generate changelogs (done by release team).

@crimsonfaith91
Copy link
Contributor Author

@janetkuo i see! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants