Automated cherry pick of #53576

[xiangpengzhao]

Cherry pick of #53576 on release-1.8.

#53576: Revert "Validate if service has duplicate targetPort"

[k8s-ci-robot]

@xiangpengzhao: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #53576.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@xiangpengzhao: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiangpengzhao
We suggest the following additional approver: brendandburns

Assign the PR to them by writing /assign @brendandburns in a comment when ready.

Associated issue: 53576

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/api/OWNERS

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[xiangpengzhao]

/cc @thockin @caseydavenport

[xiangpengzhao]

/release-note-none

[k8s-github-robot]

Automatic merge from submit-queue.

[jpbetz]

@xiangpengzhaorelease-1.8 blocking tests have started failing since this was merged:

https://k8s-testgrid.appspot.com/sig-release-1.8-blocking#gci-gke-serial-1.8

Please have a look. To keep our release timeline on plan this may need to get reverted if we cannot resolve the issue quickly.

[xiangpengzhao]

@jpbetz I find the failure log as below:

STEP: Restarting apiserver
Nov  4 14:38:55.850: INFO: Upgrading master to "1.8.3-beta.0.92+c7778dae8eb584"
Nov  4 14:38:55.850: INFO: Running gcloud [container clusters --project=gke-up-c1-4-g1-5-up-clu-n --zone=us-central1-b upgrade e2e-858 --master --cluster-version=1.8.3-beta.0.92+c7778dae8eb584 --quiet]
Nov  4 14:39:03.423: INFO: error restarting apiserver: error running gcloud [container clusters --project=gke-up-c1-4-g1-5-up-clu-n --zone=us-central1-b upgrade e2e-858 --master --cluster-version=1.8.3-beta.0.92+c7778dae8eb584 --quiet]; got error exit status 1, stdout "", stderr "Upgrading e2e-858...\n.....done.\nERROR: (gcloud.container.clusters.upgrade) Operation [<Operation\n endTime: u'2017-11-04T14:38:57.507206389Z'\n name: u'operation-1509806337229-c09d4978'\n operationType: OperationTypeValueValuesEnum(UPGRADE_MASTER, 3)\n selfLink: u'https://test-container.sandbox.googleapis.com/v1/projects/769714595857/zones/us-central1-b/operations/operation-1509806337229-c09d4978'\n startTime: u'2017-11-04T14:38:57.229764357Z'\n status: StatusValueValuesEnum(DONE, 3)\n statusMessage: u'Patch failed'\n targetLink: u'https://test-container.sandbox.googleapis.com/v1/projects/769714595857/zones/us-central1-b/clusters/e2e-858'\n zone: u'us-central1-b'>] finished with error: Patch failed\n"
STEP: deleting { ReplicationController} service1 in namespace e2e-tests-services-mzfkd
Nov  4 14:39:03.945: INFO: Deleting { ReplicationController} service1 took: 352.685476ms
Nov  4 14:39:03.945: INFO: Terminating { ReplicationController} service1 pods took: 57.537µs
Nov  4 14:39:14.045: INFO: Garbage collecting { ReplicationController} service1 pods took: 10.452934629s
[AfterEach] [sig-network] Services

This cherry-pick PR just lessened validation. I'm not sure it would fail the apiserver restarting. @thockin @bowei @freehan any thoughts?

[jpbetz]

@xiangpengzhao And this cherry-pick simply reverts a commit made in July. I'll attempt run these tests locally against GKE and gather the apiserver logs from the master.

I may concurrently revert this cherry-pick to see if that impacts the e2e test runs since it's not entirely clear if this is what is causing the e2e test failures. If it's not the cause, I'll re-apply this cherry-pick.

[xiangpengzhao]

@jpbetz thanks for babysitting this :)
BTW, I have a question, when I cherry-pick a commit to a main release, e.g, 1.8.0, is it only be patched to 1.8.0 but not to other 1.8.x releases?

[jpbetz]

@xiangpengzhao Commits are to a release branch, e.g. release-1.8, and apply to all subsequent patch releases of that branch. For example, if a cherry-pick is merged to the release-1.8 branch before the 1.8.3 release is cut, it will be included in 1.8.3, 1.8.4, 1.8.5, ...

[xiangpengzhao]

@jpbetz Thanks for explanation! :)

[xiangpengzhao]

@jpbetz seems like the test still failed after the PR was reverted:
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-gci-gke-serial-stable1/875

Any new clues in your local tests?

[jpbetz]

Haven't been able to replicate locally yet, I've filed #55244