New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GetVersion() API instead of ver command #55143
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,96 @@ | ||
// +build windows | ||
|
||
/* | ||
Copyright 2017 The Kubernetes Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package winstats | ||
|
||
import ( | ||
"fmt" | ||
"unsafe" | ||
|
||
"golang.org/x/sys/windows" | ||
) | ||
|
||
// getCurrentVersionVal gets value of speficied key from registry. | ||
func getCurrentVersionVal(key string) (string, error) { | ||
var h windows.Handle | ||
if err := windows.RegOpenKeyEx(windows.HKEY_LOCAL_MACHINE, | ||
windows.StringToUTF16Ptr(`SOFTWARE\\Microsoft\\Windows NT\\CurrentVersion\\`), | ||
0, | ||
windows.KEY_READ, | ||
&h); err != nil { | ||
return "", err | ||
} | ||
defer windows.RegCloseKey(h) | ||
|
||
var buf [128]uint16 | ||
var typ uint32 | ||
n := uint32(len(buf) * int(unsafe.Sizeof(buf[0]))) // api expects array of bytes, not uint16 | ||
if err := windows.RegQueryValueEx(h, | ||
windows.StringToUTF16Ptr(key), | ||
nil, | ||
&typ, | ||
(*byte)(unsafe.Pointer(&buf[0])), | ||
&n); err != nil { | ||
return "", err | ||
} | ||
|
||
return windows.UTF16ToString(buf[:]), nil | ||
} | ||
|
||
// getVersionRevision gets revision from UBR registry. | ||
func getVersionRevision() (uint16, error) { | ||
revisionString, err := getCurrentVersionVal("UBR") | ||
if err != nil { | ||
return 0, err | ||
} | ||
|
||
revision, err := windows.UTF16FromString(revisionString) | ||
if err != nil { | ||
return 0, err | ||
} | ||
|
||
return revision[0], nil | ||
} | ||
|
||
// getKernelVersion gets the version of windows kernel. | ||
func getKernelVersion() (string, error) { | ||
ver, err := windows.GetVersion() | ||
if err != nil { | ||
return "", err | ||
} | ||
|
||
revision, err := getVersionRevision() | ||
if err != nil { | ||
return "", err | ||
} | ||
|
||
major := ver & 0xFF | ||
minor := (ver >> 8) & 0xFF | ||
build := (ver >> 16) & 0xFFFF | ||
return fmt.Sprintf("%d.%d.%05d.%d\n", major, minor, build, revision), nil | ||
} | ||
|
||
// getOSImageVersion gets the osImage name and version. | ||
func getOSImageVersion() (string, error) { | ||
productName, err := getCurrentVersionVal("ProductName") | ||
if err != nil { | ||
return "", nil | ||
} | ||
|
||
return productName, nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if I'm reading this correctly, the value
0xABCDEF
would be parsed as:Is that correct? Or should it be the other way around?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tallclair right. A tipical example is 0x23F00206, represents 6.2.9200.