New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum supported go version to 1.9.1 #55301

Merged
merged 1 commit into from Nov 9, 2017

Conversation

@xiangpengzhao
Member

xiangpengzhao commented Nov 8, 2017

What this PR does / why we need it:
If #55293 gets merged, we should bump minimum_go_version to 1.9.1

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
ref: #51375 #55293 (comment)

Special notes for your reviewer:
/cc @cblecker @ixdy @luxas

Release note:

The minimum supported go version bumps to 1.9.1.
@cblecker

This comment has been minimized.

Member

cblecker commented Nov 8, 2017

/assign

@luxas

luxas approved these changes Nov 8, 2017

/lgtm
/approve

@luxas

This comment has been minimized.

Member

luxas commented Nov 8, 2017

/retest

Thanks @xiangpengzhao!

@xiangpengzhao

This comment has been minimized.

Member

xiangpengzhao commented Nov 8, 2017

I think there is sth wrong with CI.
Ref: kubernetes/test-infra#5400

@xiangpengzhao

This comment has been minimized.

Member

xiangpengzhao commented Nov 8, 2017

@luxas do we need an announcement for developers on the changing of minimum go version supporting? If so, can you help make the announcement please? I guess it's sth like the last announcement: https://groups.google.com/forum/#!msg/kubernetes-dev/0XRRz6UhhTM/YODWVnuDBQAJ

@luxas

This comment has been minimized.

Member

luxas commented Nov 8, 2017

@xiangpengzhao

This comment has been minimized.

Member

xiangpengzhao commented Nov 8, 2017

Oh, thanks @luxas ! I didn't check the mailing list when I copyed the previous announcement link :)

@cblecker

This comment has been minimized.

Member

cblecker commented Nov 8, 2017

/approve
/retest

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Nov 8, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, luxas, xiangpengzhao

Associated issue: 55293

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Nov 9, 2017

Automatic merge from submit-queue (batch tested with PRs 55301, 55319, 54018, 55322, 55125). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 7e1ef2f into kubernetes:master Nov 9, 2017

12 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation xiangpengzhao authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Jenkins job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Jenkins job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Jenkins job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Jenkins job succeeded.
Details
pull-kubernetes-verify Jenkins job succeeded.
Details

@xiangpengzhao xiangpengzhao deleted the xiangpengzhao:bump-min-go branch Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment