Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #48271 #55362

Merged
merged 1 commit into from
Nov 11, 2017
Merged

Automated cherry pick of #48271 #55362

merged 1 commit into from
Nov 11, 2017

Conversation

krzyzacy
Copy link
Member

@krzyzacy krzyzacy commented Nov 9, 2017

Cherry pick of #48271 on release-1.7.

#48271: Make cluster IP range an argument to ginkgo to fix firewall

@k8s-ci-robot
Copy link
Contributor

@krzyzacy: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #48271.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@krzyzacy: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 9, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 9, 2017
@krzyzacy krzyzacy mentioned this pull request Nov 9, 2017
Merged
@krzyzacy
Copy link
Member Author

krzyzacy commented Nov 9, 2017

ref kubernetes/test-infra#5416
/assign @shyamjvs @enisoc @wojtek-t

@krzyzacy
Copy link
Member Author

krzyzacy commented Nov 9, 2017

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 9, 2017
@crassirostris
Copy link

/assign @mwielgus

It's blocking the queue currently

@krzyzacy krzyzacy force-pushed the automated-cherry-pick-of-#48271-upstream-release-1.7 branch from 929bd7e to 465f2a0 Compare November 9, 2017 01:38
shyamjvs
shyamjvs reviewed Nov 9, 2017
View reviewed changes
test/e2e/framework/test_context.go Outdated
@@ -218,7 +219,7 @@ func RegisterClusterFlags() {
flag.StringVar(&cloudConfig.NodeInstanceGroup, "node-instance-group", "", "Name of the managed instance group for nodes. Valid only for gce, gke or aws. If there is more than one group: comma separated list of groups.")
flag.StringVar(&cloudConfig.Network, "network", "e2e", "The cloud provider network for this e2e cluster.")
flag.IntVar(&cloudConfig.NumNodes, "num-nodes", -1, "Number of nodes in the cluster")

flag.StringVar(&cloudConfig.ClusterIPRange, "cluster-ip-range", "10.100.0.0/14", "A CIDR notation IP range from which to assign IPs in the cluster.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same change I suggested on the 1.6 cherry-pick.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@shyamjvs
Copy link
Member

shyamjvs commented Nov 9, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2017
@shyamjvs
Copy link
Member

shyamjvs commented Nov 9, 2017

Ping @mwielgus - could you cherrypick-approve this change on @wojtek-t 's behalf (as he's on leave)?

@mwielgus
Copy link
Contributor

mwielgus commented Nov 9, 2017 •
edited
Loading

Please get this PR approved. Merge approval is given afterwards.

@shyamjvs
Copy link
Member

shyamjvs commented Nov 9, 2017

@eparis / @ixdy / @fejta Could one of you please approve the PR?

@krzyzacy krzyzacy mentioned this pull request Nov 9, 2017
Merged
@krzyzacy
Copy link
Member Author

krzyzacy commented Nov 9, 2017

😂 @shyamjvs you should add yourself to test/OWNERS earlier

@yujuhong yujuhong mentioned this pull request Nov 9, 2017
Merged
@ixdy
Copy link
Member

ixdy commented Nov 9, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, krzyzacy, shyamjvs

Associated issue: 48271

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2017
@foxish foxish removed their assignment Nov 9, 2017
@dchen1107 dchen1107 added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 10, 2017
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@ivan4th ivan4th mentioned this pull request Nov 10, 2017
Merged
@yujuhong yujuhong added this to the v1.7 milestone Nov 10, 2017
@krzyzacy
Copy link
Member Author

/retest

@krzyzacy
Copy link
Member Author

/retest
/shrug

@k8s-ci-robot k8s-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Nov 10, 2017
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 3626de1 into kubernetes:release-1.7 Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyamjvs shyamjvs shyamjvs left review comments

Assignees

@shyamjvs shyamjvs

@enisoc enisoc

@ixdy ixdy

@wojtek-t wojtek-t

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet