New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add script to verify build tags #55749
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cblecker No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/retest |
I'd like to tighten up cross this week so we can avoid more unnecessary breakage going into 1.9, this PR is SGTM for that. |
@cblecker: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Closing in favour of #59289 |
What this PR does / why we need it:
Adds a script to verify build tags are only present in files with a proper extension.
This doesn't yet fix all the files that are non-conformant, and is a work in progress.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #55750
Release note: