Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in component name of prometheus-to-sd config. #56473

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

loburm
Copy link
Contributor

@loburm loburm commented Nov 28, 2017

Fixes GoogleCloudPlatform/k8s-stackdriver#70

Fix a typo in prometheus-to-sd configuration, that drops some stackdriver metrics.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 28, 2017
@loburm
Copy link
Contributor Author

loburm commented Nov 28, 2017

/test pull-kubernetes-unit
/test pull-kubernetes-e2e-gke-gci

@loburm
Copy link
Contributor Author

loburm commented Nov 28, 2017

/test pull-kubernetes-verify

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 28, 2017

@loburm: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gke-gci 3d7a694 link /test pull-kubernetes-e2e-gke-gci

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@crassirostris
Copy link

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2017
@crassirostris crassirostris added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. status/approved-for-milestone labels Nov 28, 2017
@crassirostris crassirostris added this to the v1.9 milestone Nov 28, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crassirostris, loburm

Associated issue requirement bypassed by: crassirostris

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@crassirostris crassirostris added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Nov 28, 2017
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Current

@crassirostris @loburm @piosz

Note: This pull request is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required
Pull Request Labels
  • sig/instrumentation: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 56344, 56473). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 912d817 into kubernetes:master Nov 28, 2017
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 28, 2017
k8s-github-robot pushed a commit that referenced this pull request Nov 29, 2017
…-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #56473

Cherry pick of #56473 on release-1.7.

#56473: Fix typo in component name of prometheus-to-sd config.
k8s-github-robot pushed a commit that referenced this pull request Nov 30, 2017
…-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #56473

Cherry pick of #56473 on release-1.8.

#56473: Fix typo in component name of prometheus-to-sd config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants