[Test Fix] Fake docker client can remove containers which have not been started

[dashpole]

What this PR does / why we need it:
During kubemark-5000 scalability tests, which use the fake docker client, we encountered a bug where containers where the pod was deleted before the container was started could not be deleted.
This is because we only remove pods from the ExitedContainers list. Containers are only added to this when they have been created, started, and then stopped. However, containers that have only been created, but not started cannot be deleted. This PR fixes this issue by allowing containers with State.Running=false to be deleted.

Which issue(s) this PR fixes:
Ref #53327

Release note:

NONE

/sig node
/kind bug
/priority critical-urgent
/assign @Random-Liu @dchen1107 @shyamjvs

[dashpole]

/retest

[dashpole]

/retest

[k8s-github-robot]

[MILESTONENOTIFIER] Milestone Pull Request Needs Attention

@Random-Liu @dashpole @dchen1107 @shyamjvs @kubernetes/sig-node-misc

Action required: During code freeze, pull requests in the milestone should be in progress.
If this pull request is not being actively worked on, please remove it from the milestone.
If it is being worked on, please add the status/in-progress label so it can be tracked with other in-flight pull requests.

Note: This pull request is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required

Pull Request Labels

• sig/node: Pull Request will be escalated to these SIGs if needed.
• priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
• kind/bug: Fixes a bug discovered during the current release.

Help

• Additional instructions
• Commands for setting labels

[shyamjvs]

Approved for milestone as this is an important fix for failing kubemark tests.

/lgtm
Will let someone from node team also to review.

[shyamjvs]

@krzyzacy The kubemark presubmit failure here seems to be due to your D-in-D migration?

I1204 23:21:08.408] Copying kubemark binary to /go/src/k8s.io/kubernetes/kubernetes/cluster/images/kubemark
I1204 23:21:08.557] docker build --pull -t gcr.io/k8s-jkns-pr-kubemark/kubemark .
W1204 23:21:09.544] Cannot connect to the Docker daemon. Is the docker daemon running on this host?
W1204 23:21:09.547] make: *** [build] Error 1

[shyamjvs]

/retest

(hoping it's fixed with kubernetes/test-infra#5807)

[krzyzacy]

obviously missed retest here, it should pass now.

[shyamjvs]

Hmm.. it seems like the pull job is already using the new image. Do you know what happened?

[shyamjvs]

Ok.. let's see.

[krzyzacy]

yeah, I fixed this in kubernetes/test-infra#5802

[wojtek-t]

/approve

@dashpole - thanks for the fix!

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, shyamjvs, wojtek-t

Associated issue: 53327

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/kubelet/OWNERS [wojtek-t]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[shyamjvs]

/retest

[k8s-github-robot]

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.