Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the comments on webhook failure policy #56874

Merged
merged 1 commit into from Jan 25, 2018
Merged

Update the comments on webhook failure policy #56874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions pkg/apis/admissionregistration/types.go
View file
Open in desktop
Expand Up @@ -106,11 +106,9 @@ type Rule struct {
type FailurePolicyType string

const (
// Ignore means the initializer is removed from the initializers list of an
// object if the initializer is timed out.
// Ignore means that an error calling the webhook is ignored.
Ignore FailurePolicyType = "Ignore"
// For 1.7, only "Ignore" is allowed. "Fail" will be allowed when the
// extensible admission feature is beta.
// Fail means that an error calling the webhook causes the admission to fail.
Fail FailurePolicyType = "Fail"
)

Expand Down
6 changes: 2 additions & 4 deletions staging/src/k8s.io/api/admissionregistration/v1beta1/types.go
View file
Open in desktop
Expand Up @@ -54,11 +54,9 @@ type Rule struct {
type FailurePolicyType string

const (
// Ignore means the initializer is removed from the initializers list of an
// object if the initializer is timed out.
// Ignore means that an error calling the webhook is ignored.
Ignore FailurePolicyType = "Ignore"
// For 1.7, only "Ignore" is allowed. "Fail" will be allowed when the
// extensible admission feature is beta.
// Fail means that an error calling the webhook causes the admission to fail.
Fail FailurePolicyType = "Fail"
)

Expand Down