Fixing vSphere Cloud Provider to use "vsphere-cloud-provider" to create ClientBuilder

[rjog]

What this PR does / why we need it:
vSphere cloud Provider is not using lower case naming while creating clientBuilder.
With this fix, ClientBuilder is created using lowercase naming.
With mixed upper-lower case name, controller manager is crashing.

Which issue(s) this PR fixes
Fixes # #57279

Special notes for your reviewer:
None

Release note:

Fixes controller manager crash in certain vSphere cloud provider environment.

[rjog]

/assign @abrarshivani

[dims]

/ok-to-test

[liggitt]

CI isn't going to do much for us here, since this was failing as-is and wasn't caught by CI

[dims]

totally @liggitt we'd need that just to keep the bots happy (and get the thing merged eventually). Not sure if there is a way to do this without kicking off the tests for folks who are not maintainers

[abrarshivani]

@rohitjogvmw Where you able to produce same failure scenario?

[abrarshivani]

@rohitjogvmw I was able to succeed in deploying a K8s cluster with official google container image (gcr.io/google_containers/hyperkube-amd64:v1.9.0) and cloud provider as vsphere.

> kubectl version
Client Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.0", GitCommit:"925c127ec6b946659ad0fd596fa959be43f0cc05", GitTreeState:"clean", BuildDate:"2017-12-15T21:07:38Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.0", GitCommit:"925c127ec6b946659ad0fd596fa959be43f0cc05", GitTreeState:"clean", BuildDate:"2017-12-15T20:55:30Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"linux/amd64"}

[andremarianiello]

@abrarshivani I also ran into this issue. kubectl version also works for me, because this issue affects the controller manager, not the api server. If you look, you should see that the controller manager has crashed and that no service accounts, including vsphere's, have been created.

kubectl get serviceaccounts --all-namespaces

[rjog]

Hi @abrarshivani,
Issue is getting solved with my change.
Can you please approve the PR?

[abrarshivani]

@andremarianiello For me controller manager is up all the time. It seems that @rohitjogvmw has successfully tested and verified the fix.

@rohitjogvmw Sure, I will approve it. BTW, just curious to know how you were able to reproduce it?

[abrarshivani]

/approve

[andremarianiello]

@abrarshivani what is the name of the created vsphere service account on your healthy cluster?

[rjog]

@abrarshivani, my change is confirmed by @andremarianiello.
Can you also add lgtm label?

[abrarshivani]

@andremarianiello Thanks for validating the change. Following are the pods running on Kubernetes cluster configured with vsphere cloud provider.

> kubectl get pods --all-namespaces
NAMESPACE     NAME                                        READY     STATUS    RESTARTS   AGE
kube-system   etcd-server-kubernetes-master               1/1       Running   0          13m
kube-system   heapster-v1.2.0-757f46b777-9nw62            2/2       Running   0          14m
kube-system   kube-apiserver-kubernetes-master            1/1       Running   0          14m
kube-system   kube-controller-manager-kubernetes-master   1/1       Running   0          13m
kube-system   kube-dns-v19-qptlp                          3/3       Running   0          14m
kube-system   kube-dns-v19-wcpb5                          3/3       Running   0          14m
kube-system   kube-proxy-gh527                            1/1       Running   0          14m
kube-system   kube-proxy-gwsxv                            1/1       Running   0          14m
kube-system   kube-proxy-r5k65                            1/1       Running   0          14m
kube-system   kube-scheduler-kubernetes-master            1/1       Running   0          13m
kube-system   kubernetes-dashboard-6ff67cd6-5fcz9         1/1       Running   0          14m

Following are the service accounts,

> kubectl get serviceaccounts --all-namespaces
NAMESPACE     NAME      SECRETS   AGE
default       default   1         12m
kube-public   default   1         12m
kube-system   default   1         12m

K8s cluster version:

> kubectl version
Client Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.0", GitCommit:"925c127ec6b946659ad0fd596fa959be43f0cc05", GitTreeState:"clean", BuildDate:"2017-12-15T21:07:38Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.0", GitCommit:"925c127ec6b946659ad0fd596fa959be43f0cc05", GitTreeState:"clean", BuildDate:"2017-12-15T20:55:30Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"linux/amd64"}

[abrarshivani]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrarshivani, rohitjogvmw

Associated issue: #57279

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/cloudprovider/providers/vsphere/OWNERS [abrarshivani]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[rjog]

/test pull-kubernetes-e2e-gce

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.