[FC Plugin] Create proper volumeSpec during ConstructVolumeSpec #58089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
rootfs
reviewed
Jan 10, 2018
| // Create volume from wwn+lun or wwid | ||
| var fcVolume *v1.Volume | ||
| if strings.Contains(volumeInfo, "-lun-") { | ||
| wwnLun := strings.Split(volumeInfo, "-lun-") |
rootfs
reviewed
Jan 10, 2018
| @@ -235,11 +235,56 @@ func (plugin *fcPlugin) newUnmapperInternal(volName string, podUID types.UID, ma | |||
| } | |||
|
|
|||
| func (plugin *fcPlugin) ConstructVolumeSpec(volumeName, mountPath string) (*volume.Spec, error) { | |||
There was a problem hiding this comment.
can you add a unit test too?
There was a problem hiding this comment.
@rootfs
Do you have an idea to mock up mount.GetMountRefs(mounter, mountPath)?
Currently, FC plugin returns volume name and empty FCVolumeSource during ConstrutVolumeSpec during filesystem volume's reconstruction. In this fix, ConstructVolumeSpec retrieves global mount path, analyzes volume parameters such as WWN, LUN, WWID from the path. Fixes kubernetes#58085
k8s-ci-robot
added
size/L
|
/approve |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtanino, rootfs Associated issue: #58085 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, FC plugin returns volume name and empty FCVolumeSource during ConstrutVolumeSpec of filesystem volume's reconstruction.
In this fix, ConstructVolumeSpec retrieves global mount path, and analyzes volume parameters such as
WWN, LUN, WWID from the path.
Which issue(s) this PR fixes :
Fixes #58085
Special notes for your reviewer:
Release note:
cc @rootfs @jsafrane
/sig storage