Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #57861: Use existing subnetwork of forwarding rule #58110

Merged
merged 1 commit into from
Jan 11, 2018
Merged

Automated cherry pick of #57861: Use existing subnetwork of forwarding rule #58110

merged 1 commit into from
Jan 11, 2018

Conversation

nicksardo
Copy link
Contributor

@nicksardo nicksardo commented Jan 10, 2018 •
edited
Loading

Cherry pick of #57861 on release-1.9.

#57861: Use existing subnetwork of forwarding rule

Release note:

GCE: Allows existing internal load balancers to continue using an outdated subnetwork

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 10, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 10, 2018
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 10, 2018
@nicksardo
Copy link
Contributor Author

/assign @bowei
/unassign lavalamp erictune

@k8s-ci-robot k8s-ci-robot assigned bowei and unassigned lavalamp and erictune Jan 10, 2018
@bowei
Copy link
Member

bowei commented Jan 10, 2018

/lgtm
/approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, nicksardo

Associated issue: #57861

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@nicksardo
Copy link
Contributor Author

/assign @mbohlool

@mbohlool mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 11, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@nicksardo
Copy link
Contributor Author

/test pull-kubernetes-bazel-build

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@nicksardo
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 33d8d8e into kubernetes:release-1.9 Jan 11, 2018
@nicksardo nicksardo deleted the automated-cherry-pick-of-#57861-upstream-release-1.9 branch January 12, 2018 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bowei bowei

@mbohlool mbohlool

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@nicksardo @bowei @k8s-ci-robot @k8s-github-robot @fejta-bot @lavalamp @mbohlool @erictune