Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #57978 upstream release-1.9 #58124

Merged
merged 1 commit into from Jan 17, 2018
Merged

Automated cherry pick of #57978 upstream release-1.9 #58124

merged 1 commit into from Jan 17, 2018

Conversation

divyenpatel
Copy link
Member

Cherry pick of #57978 on release-1.9
#57978: Renews cached NodeInfo with new vSphere connection

Release note:

Fixes authentication problem faced during various vSphere operations.

cc: @prashima

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 11, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 11, 2018
@divyenpatel
Copy link
Member Author

/assign @luomiao

@divyenpatel divyenpatel mentioned this pull request Jan 11, 2018
Closed
@luomiao
Copy link

luomiao commented Jan 11, 2018

/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 11, 2018
@caesarxuchao
Copy link
Member

/retest

@caesarxuchao caesarxuchao removed their assignment Jan 11, 2018
@mbohlool mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 12, 2018
@prashima prashima mentioned this pull request Jan 12, 2018
Closed
3 tasks
@mbohlool
Copy link
Contributor

/retest

@cblecker
Copy link
Member

/test pull-kubernetes-cross

1 similar comment
@mbohlool
Copy link
Contributor

/test pull-kubernetes-cross

@mbohlool
Copy link
Contributor

@divyenpatel can you see why the test is failing. We need to get this in today if you want it to be part of 1.9.2.

@mbohlool
Copy link
Contributor

/lgtm
Move lgtm from parent PR (luomiao were LGTM that one and approve this one).

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, luomiao, mbohlool

Associated issue: #57978

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 5fa2db2 into kubernetes:release-1.9 Jan 17, 2018
@divyenpatel divyenpatel mentioned this pull request Jan 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbohlool mbohlool

@luomiao luomiao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@divyenpatel @luomiao @caesarxuchao @mbohlool @cblecker @k8s-ci-robot @k8s-github-robot @prashima