cluster: remove salt #58248
cluster: remove salt #58248
Conversation
k8s-ci-robot
added
release-note
mikedanese
force-pushed
the
rm-salt
branch
2 times, most recently
from
e211bd1
to
e26af25
Compare
|
/retest |
mikedanese
force-pushed
the
rm-salt
branch
3 times, most recently
from
9b99bec
to
6fbb028
Compare
k8s-github-robot
added
the
needs-rebase
k8s-github-robot
removed
the
needs-rebase
|
|
||
| local release_stage="${RELEASE_STAGE}/manifests/kubernetes" | ||
| rm -rf "${release_stage}" | ||
|
|
||
| mkdir -p "${release_stage}" | ||
| cp "${salt_dir}/kube-registry-proxy/kube-registry-proxy.yaml" "${release_stage}/" |
There was a problem hiding this comment.
These files moved to a different dir in the tar, but I don't see a corresponding change in the node setup scripts.
There was a problem hiding this comment.
changes are in cluster/gce/gci/configure-helper.sh
There was a problem hiding this comment.
I see it now. thanks.
basically just: * move all manifests into the new gce/manifests dir * move limit-range into gce/addons/limit-range * move abac jsonl into gce/manifests. this is gross but we will hopefully be able to delete this config soon. it only exists to support a deprecated feature. * fix build, release, deploy to look for everything in its new home
and don't build kubernetes-salt.tar.gz
|
/retest |
|
@roberthbailey all green |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikedanese, roberthbailey Associated issue: #49213 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
|
woo! |
|
@mikedanese: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue (batch tested with PRs 58697, 58658, 58676, 58674). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove salt configuration from the fluentd-gcp configuration. Remove a bit of left-over salt. This was missed in #58248 xref: #49213 **Release note**: ```release-note NONE ```
Nothing uses it directly. There were some dangling dependencies from GCE and Centos kube-ups, so I just copied them into respective dirs.
see #49213