[1.7] Automated cherry pick of #57422: Rework method of updating atomic-updated data volumes #58463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change affects the way that secret, configmap, downwardAPI and projected volumes (which all use the same underlying code) implement their data update functionality. * Instead of creating a subdirectory hierarchy that itself will contain symlinks to each actual data file, create only symlinks to items in the root of the volume, whether they be files or directories. * Rather than comparing the user-visible data directory to see if an update is needed, compare with the current version of the data directory. * Fix data dir timestamp format year * Create ..data symlink even when a data volume has no data so consumers can have simplified update watch logic.
k8s-ci-robot
added
size/L
k8s-github-robot
added
the
do-not-merge/cherry-pick-not-approved
|
Should we pick it in 1.9 first and then 1.8 and 1.7? |
jsafrane
changed the title
|
It's already picked, sorry for the noise. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelsmith, jsafrane Associated issue: #57422 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
|
/assign @wojtek-t |
wojtek-t
added
cherry-pick-approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/test pull-kubernetes-unit |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
joelsmith
deleted the
automated-cherry-pick-of-#57422-upstream-release-1.7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #57422 on release-1.7.
#57422: Rework method of updating atomic-updated data volumes
Fixes #60814 for 1.7