Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature Gate - Kubeadm Audit Logging #59067
Signed-off-by: Chuck Ha email@example.com
What this PR does / why we need it:
Special notes for your reviewer:
Need some feedback on knob & default before we continue.
@chuckha :+1 for this PR!
Two high level comments about the implementation:
- if we are extending how static pod manifest are created in
kubeadm init, it is necessary to ensure a consistent behaviour also in
kubeadm alpha phase controlplane(e.g. same flags, same logic for the creation of the policy file if it doesn't exists).
- the dependency from the kubea-apiserver to the audit policy file introduce a new element that should be taken into account for self-hosting and HA. I think it is important to inform as many people as possible about this. @timothysc, what about discussing this in the next SIG-meeting?
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these OWNERS Files:
Approvers can indicate their approval by writing