Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure IP is set for Azure internal loadbalancer #59083

Merged
merged 1 commit into from Feb 2, 2018

Conversation

@feiskyer
Copy link
Member

commented Jan 31, 2018

What this PR does / why we need it:

Internal Load Balancer created and associated with availability set but no target network ip configurations on Azure. And kube-controller-manager would panic because of nil pointer dereference.

This PR ensures it is set correctly.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #59046

Special notes for your reviewer:

Should cherry-pick to v1.9

Release note:

Ensure IP is set for Azure internal load balancer.
@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Jan 31, 2018

/kind bug

@karataliu

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2018

Ideally we might try evaluating LB result from CreateOrUpdateLBWithRetry to save a get call.

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, karataliu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Feb 1, 2018

Ideally we might try evaluating LB result from CreateOrUpdateLBWithRetry to save a get call.

We may add this when adding caches.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Feb 2, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Feb 2, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d8605eb into kubernetes:master Feb 2, 2018

12 of 13 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation feiskyer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@brendandburns

This comment has been minimized.

Copy link
Contributor

commented Feb 2, 2018

We should cherry-pick this into 1.9.x...

@brendandburns

This comment has been minimized.

Copy link
Contributor

commented Feb 2, 2018

Created #59277

@feiskyer feiskyer deleted the feiskyer:fix-59046 branch Feb 2, 2018

@jdumars jdumars added this to the v1.9 milestone Feb 5, 2018

k8s-github-robot pushed a commit that referenced this pull request Feb 6, 2018
Kubernetes Submit Queue
Merge pull request #59277 from brendandburns/automated-cherry-pick-of…
…-#59083-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #59083: Ensure IP is set for Azure internal loadbalancer

Cherry pick of #59083 on release-1.9.

#59083: Ensure IP is set for Azure internal loadbalancer
@k8s-cherrypick-bot

This comment has been minimized.

Copy link

commented Feb 6, 2018

Commit found in the "release-1.9" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.