Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure IP is set for Azure internal loadbalancer #59083

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

feiskyer
Copy link
Member

What this PR does / why we need it:

Internal Load Balancer created and associated with availability set but no target network ip configurations on Azure. And kube-controller-manager would panic because of nil pointer dereference.

This PR ensures it is set correctly.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #59046

Special notes for your reviewer:

Should cherry-pick to v1.9

Release note:

Ensure IP is set for Azure internal load balancer.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 31, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2018
@feiskyer
Copy link
Member Author

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 31, 2018
@karataliu
Copy link
Contributor

Ideally we might try evaluating LB result from CreateOrUpdateLBWithRetry to save a get call.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, karataliu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@feiskyer
Copy link
Member Author

feiskyer commented Feb 1, 2018

Ideally we might try evaluating LB result from CreateOrUpdateLBWithRetry to save a get call.

We may add this when adding caches.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d8605eb into kubernetes:master Feb 2, 2018
@brendandburns
Copy link
Contributor

We should cherry-pick this into 1.9.x...

@brendandburns
Copy link
Contributor

Created #59277

@feiskyer feiskyer deleted the fix-59046 branch February 2, 2018 23:03
@jdumars jdumars added this to the v1.9 milestone Feb 5, 2018
k8s-github-robot pushed a commit that referenced this pull request Feb 6, 2018
…-#59083-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #59083: Ensure IP is set for Azure internal loadbalancer

Cherry pick of #59083 on release-1.9.

#59083: Ensure IP is set for Azure internal loadbalancer
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.9" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Internal Load Balancer not automatically adding target network IP configurations
7 participants