Remove method NewCronJobControllerFromClient #59471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was originally introduced when cronjob was still called scheduledjob: 7a34347 Back then, both init methods had different signatures. Since the rename to cronjob (41d88d3), this method is an alias to the normal initializer, have the same signature and is not used anywhere in the codebase. Since this method was never actually used for cronjobs, it doesn't seem removing it would need any deprecation notice.
k8s-ci-robot
added
release-note
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/retest |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmathieu, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
soltysh
added
area/batch
sig/apps
k8s-ci-robot
added
the
approved
|
/retest |
|
/kind cleanup |
k8s-ci-robot
added
the
kind/cleanup
|
/priority important-longterm |
k8s-ci-robot
added
the
priority/important-longterm
|
[MILESTONENOTIFIER] Milestone Pull Request Needs Approval @dmathieu @soltysh @kubernetes/sig-apps-misc Action required: This pull request must have the Pull Request Labels
|
k8s-github-robot
added
milestone/needs-approval
and removed
milestone/incomplete-labels
labels
|
/retest Review the full test history for this PR. Silence the bot with an |
|
/retest |
|
Automatic merge from submit-queue (batch tested with PRs 60632, 60806, 59471, 61251, 61013). If you want to cherry-pick this change to another branch, please follow the instructions here. |
hiddeco
pushed a commit
to hiddeco/kubernetes
that referenced
this pull request
Apr 6, 2020
…-client Automatic merge from submit-queue (batch tested with PRs 60632, 60806, 59471, 61251, 61013). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove method NewCronJobControllerFromClient **What this PR does / why we need it**: This method was originally introduced when cronjob was still called scheduledjob: kubernetes@7a34347 Back then, both init methods had different signatures. Since the rename to cronjob (kubernetes@41d88d3), this method is an alias to the normal initializer, have the same signature and is not used anywhere in the codebase. Since this method was never actually used for cronjobs, it doesn't seem removing it would need any deprecation notice. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note Remove never used NewCronJobControllerFromClient method ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This method was originally introduced when cronjob was still called scheduledjob: 7a34347
Back then, both init methods had different signatures.
Since the rename to cronjob (41d88d3), this method is an alias to the normal initializer, have the same signature and is not used anywhere in the codebase.
Since this method was never actually used for cronjobs, it doesn't seem removing it would need any deprecation notice.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: