Set leader-elect for kube-scheduler to true / Adds new configuration types and rework how we set defaults

[dims]

What this PR does / why we need it:
Thanks to some great sleuthing by ikruglov!

kube-controller-manager defaults --leader-elect to true. We should
do the same for kube-scheduler. kube-scheduler used to have this
set to true, but it got lost during refactoring in:
efb2bb7

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #59729

Special notes for your reviewer:

Release note:

kube-scheduler has been fixed to use `--leader-elect` option back to true (as it was in previous versions)

[dims]

/assign @timothysc

[timothysc]

/lgtm
/approve

[liggitt]

seems like defaults should be applied in defaults.go, not here (and options round-tripped through those defaults)

[dims]

i was trying to match what is done in kube-controller ... will fix https://github.com/kubernetes/kubernetes/blob/master/cmd/cloud-controller-manager/app/options/options.go#L52

[liggitt]

/hold

[liggitt]

why is this default different than all the other defaults for the scheduler config, applied in the api defaulting path? the setting here won't get applied when reading from file

[dims]

@liggitt looks like we need to do both ... cmd/kube-scheduler/app/server.go and pkg/apis/componentconfig/v1alpha1/defaults.go if i don't patch up server.go, then the command line default is still false.

[liggitt]

if i don't patch up server.go, then the command line default is still false.

that means the internal config is not being round tripped and defaulted... that seems like it should be fixed as well

[dims]

@liggitt can you point me to an existing pattern/files where this is done please?

[liggitt]

@liggitt can you point me to an existing pattern/files where this is done please?

for kubeproxy:

kubernetes/cmd/kube-proxy/app/server.go

Lines 303 to 343 in fdeaa8c

	func (o *Options) ApplyDefaults(in *kubeproxyconfig.KubeProxyConfiguration) (*kubeproxyconfig.KubeProxyConfiguration, error) {
	external, err := o.scheme.ConvertToVersion(in, v1alpha1.SchemeGroupVersion)
	if err != nil {
	return nil, err
	}
	o.scheme.Default(external)
	internal, err := o.scheme.ConvertToVersion(external, kubeproxyconfig.SchemeGroupVersion)
	if err != nil {
	return nil, err
	}
	out := internal.(*kubeproxyconfig.KubeProxyConfiguration)
	return out, nil
	}
	// NewProxyCommand creates a *cobra.Command object with default parameters
	func NewProxyCommand() *cobra.Command {
	opts := NewOptions()
	cmd := &cobra.Command{
	Use: "kube-proxy",
	Long: `The Kubernetes network proxy runs on each node. This
	reflects services as defined in the Kubernetes API on each node and can do simple
	TCP and UDP stream forwarding or round robin TCP and UDP forwarding across a set of backends.
	Service cluster IPs and ports are currently found through Docker-links-compatible
	environment variables specifying ports opened by the service proxy. There is an optional
	addon that provides cluster DNS for these cluster IPs. The user must create a service
	with the apiserver API to configure the proxy.`,
	Run: func(cmd *cobra.Command, args []string) {
	verflag.PrintAndExitIfRequested()
	cmdutil.CheckErr(opts.Complete())
	cmdutil.CheckErr(opts.Validate(args))
	cmdutil.CheckErr(opts.Run())
	},
	}
	var err error
	opts.config, err = opts.ApplyDefaults(opts.config)

for kubelet:

kubernetes/cmd/kubelet/app/options/options.go

Lines 255 to 268 in fdeaa8c

	// NewKubeletConfiguration will create a new KubeletConfiguration with default values
	func NewKubeletConfiguration() (*kubeletconfig.KubeletConfiguration, error) {
	scheme, _, err := kubeletscheme.NewSchemeAndCodecs()
	if err != nil {
	return nil, err
	}
	versioned := &v1alpha1.KubeletConfiguration{}
	scheme.Default(versioned)
	config := &kubeletconfig.KubeletConfiguration{}
	if err := scheme.Convert(versioned, config, nil); err != nil {
	return nil, err
	}
	return config, nil
	}

[dims]

Thanks @liggitt looks like it was already setup. but there was a mismatch in bool vs *bool for LeaderElect (in the 2 types.go file) and a hard coding of LeaderElect to false in DefaultLeaderElectionConfiguration.

[dims]

/milestone clear

[dims]

we merged a small change and pushing this PR off to v1.11

[dims]

@mtaufen @liggitt let's get this in please? now that master is open for 1.11. thanks!

[k8s-github-robot]

[MILESTONENOTIFIER] Milestone Removed From Pull Request

@deads2k @dims @mtaufen @timothysc

Important: This pull request was missing labels required for the v1.11 milestone for more than 3 days:

kind: Must specify exactly one of kind/bug, kind/cleanup or kind/feature.
priority: Must specify exactly one of priority/critical-urgent, priority/important-longterm or priority/important-soon.

Help

• Additional instructions
• Commands for setting labels

[dims]

@liggitt now that master is open and it's early in the cycle, let's please get this in.

[liggitt]

Why does this need type info? It's not a top level type, right?

[dims]

@liggitt some of the tests fail without it

[liggitt]

unless this is serialized in standalone way (which I'm not aware of), this should not have type info. tests that fail without that should be fixed.

[dims]

ack removing it

[dims]

Ready and all green now @liggitt . thanks!

[liggitt]

these should probably end up in controllermanager.config.k8s.io under pkg/controller/apis, similar to kubelet. can you move them in a follow up?

[dims]

yes i can

[liggitt]

thanks
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, dims, liggitt, timothysc, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/cloud-controller-manager/OWNERS [wlan0]
• cmd/controller-manager/OWNERS [deads2k]
• cmd/kube-controller-manager/OWNERS [deads2k]
• cmd/kube-scheduler/OWNERS [timothysc]
• pkg/apis/componentconfig/OWNERS [liggitt]
• pkg/client/OWNERS [deads2k,liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[bsalamat]

Could you please update the title of this PR and state that it adds new configuration types?

[k8s-github-robot]

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.