Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reviewers for sig-scheduling. #59944

Merged
merged 1 commit into from Feb 16, 2018
Merged

Update reviewers for sig-scheduling. #59944

merged 1 commit into from Feb 16, 2018

Conversation

aveshagarwal
Copy link
Member

@aveshagarwal aveshagarwal commented Feb 15, 2018 •
edited

@bsalamat @timothysc @kubernetes/sig-scheduling-misc

Release note:

None

@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 15, 2018
@aveshagarwal
Copy link
Member Author

aveshagarwal commented Feb 15, 2018 •
edited

/remove @kubernetes/sig-scalability

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 15, 2018
@aveshagarwal
Copy link
Member Author

@kubernetes/sig-scheduling-misc

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Feb 15, 2018
@aveshagarwal
Copy link
Member Author

/remove-sig-scalability

@aveshagarwal
Copy link
Member Author

/test pull-kubernetes-node-e2e

timothysc
timothysc approved these changes Feb 15, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2018
@timothysc
Copy link
Member

/approve

@bsalamat
Copy link
Member

/approve no-issue

@dchen1107
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aveshagarwal, bsalamat, dchen1107, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 59873, 59933, 59923, 59944, 59953). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f600835 into kubernetes:master Feb 16, 2018
@aveshagarwal aveshagarwal deleted the master-update-reviewers branch February 19, 2018 20:08
@wojtek-t wojtek-t mentioned this pull request Mar 21, 2018
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc approved these changes

@lavalamp lavalamp Awaiting requested review from lavalamp

@thockin thockin Awaiting requested review from thockin

Assignees

@timothysc timothysc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aveshagarwal @timothysc @bsalamat @dchen1107 @k8s-ci-robot @k8s-github-robot