-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extraneous CHANGELOGS on the 1.10 branch. #59960
Remove extraneous CHANGELOGS on the 1.10 branch. #59960
Conversation
@david-mcmahon: Adding do-not-merge/release-note-label-needed because the release note process has not been followed. One of the following labels is required "release-note", "release-note-action-required", or "release-note-none". Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'll defer to @calebamiles to add the lgtm label.
/lgtm |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: calebamiles, david-mcmahon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@cjwagner tests above are failing with
|
total speculation that kubernetes/test-infra#6919 would fix the above test failure. Better question is why this works for 1.9 |
/retest Review the full test history for this PR. Silence the bot with an |
/retest |
Automatic merge from submit-queue. |
What this PR does / why we need it:
Initial change on a new branch so we can tag a commit that doesn't exist on master.
This normally happens during the course of a release, automatically via
anago
. This provides an opportunity here to fix the issue at branch time, described in detail below.ref kubernetes/sig-release#85