-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support completion for kubectl cp #60371
Support completion for kubectl cp #60371
Conversation
With this commit, kubectl cp supports completion. ``` $ kubectl cp kube-system/ () kube-system/kube-state-metrics-769566fdfb-4v52s: kube-system/kubernetes-dashboard-6b6ddbd46-t5bv9: kube-system/prometheus-694594c45b-qk5lq: ```
8375ca2
to
8d58e70
Compare
/ok-to-test |
This looks fine to me. |
@eparis this sort of thing smells like you. You done completions before? I don't really know what it does. |
/assign @juanvallejo |
lgtm. From what I understand, you'll need to specify a namespace |
@juanvallejo No. This completion completes filedirs,
|
/test pull-kubernetes-integration |
@deads2k Any other concerns before approval? |
/test pull-kubernetes-integration |
1 similar comment
it looks plausible. I guess I'll trust it does good things. In big clusters, the general approach seems questionable. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, deads2k, superbrothers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue (batch tested with PRs 63526, 60371, 63444). If you want to cherry-pick this change to another branch, please follow the instructions here. |
@superbrothers: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it: With this PR, kubectl cp supports completion. I tested this PR in bash and zsh.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes kubernetes/kubectl#5
Special notes for your reviewer: @cblecker
Release note: