-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support completion for kubectl apply view/edit-last-applied #60499
Support completion for kubectl apply view/edit-last-applied #60499
Conversation
/ok-to-test |
@@ -168,7 +168,8 @@ __kubectl_require_pod_and_container() | |||
__custom_func() { | |||
case ${last_command} in | |||
kubectl_get | kubectl_describe | kubectl_delete | kubectl_label | kubectl_edit | kubectl_patch |\ | |||
kubectl_annotate | kubectl_expose | kubectl_scale | kubectl_autoscale | kubectl_taint | kubectl_rollout_*) | |||
kubectl_annotate | kubectl_expose | kubectl_scale | kubectl_autoscale | kubectl_taint | kubectl_rollout_* |\ | |||
kubectl_apply_edit-last-applied | kubectl_apply_view-last-applied) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's also a set-last-applied
we can add it.
@mengqiy @superbrothers I tried on my laptop, it works well, there's only one
|
@shiywang
|
@superbrothers oh, sorry : ) |
@shiywang Thank you for your review! ;) |
45edf1a
to
1989aa5
Compare
/lgtm |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mengqiy, shiywang, superbrothers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Review the full test history for this PR. Silence the bot with an |
Automatic merge from submit-queue (batch tested with PRs 60499, 61715, 61688, 61300, 58787). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it: With this PR,
kubectl apply view/edit-last-applied
support completion.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: