Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fluentd-gcp addon] Fix passing location to event exporter #60503

Merged
merged 1 commit into from
Mar 6, 2018
Merged

[fluentd-gcp addon] Fix passing location to event exporter #60503

merged 1 commit into from
Mar 6, 2018

Conversation

serathius
Copy link
Contributor

@serathius serathius commented Feb 27, 2018 •
edited

Fix passing argument to event-expoter in #58090

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2018
@serathius serathius mentioned this pull request Feb 27, 2018
Merged
@coffeepac
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 27, 2018
@serathius
Copy link
Contributor Author

/assign @crassirostris

@serathius serathius closed this Feb 28, 2018
@serathius
Copy link
Contributor Author

Because of failing GKE I extracted fix for tests in separate PR #60566

@serathius serathius deleted the fix-passing-location branch March 2, 2018 08:10
@serathius serathius restored the fix-passing-location branch March 2, 2018 08:10
@serathius serathius reopened this Mar 5, 2018
@thockin
Copy link
Member

thockin commented Mar 5, 2018

This change is Reviewable

@serathius
Copy link
Contributor Author

/test pull-kubernetes-e2e-gke

@crassirostris
Copy link

This is a small bugfix and I think it should go into 1.10

@crassirostris crassirostris added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Mar 6, 2018
@crassirostris crassirostris added this to the v1.10 milestone Mar 6, 2018
@crassirostris
Copy link

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crassirostris, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2018
@crassirostris crassirostris added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Mar 6, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@crassirostris @serathius

Pull Request Labels
  • sig/instrumentation: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 100d829 into kubernetes:master Mar 6, 2018
@loburm loburm mentioned this pull request Mar 13, 2018
Merged
@serathius serathius deleted the fix-passing-location branch July 11, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coffeepac coffeepac Awaiting requested review from coffeepac

@piosz piosz Awaiting requested review from piosz

Assignees

@crassirostris crassirostris

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@serathius @coffeepac @thockin @crassirostris @k8s-ci-robot @k8s-github-robot