New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readme for coredns #61040
Add readme for coredns #61040
Conversation
Signed-off-by: Paco Xu <paco.xu@daocloud.io> Add some links and simple descriptions to this folder as there are also another option "coredns"
Add README.md for coredns
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pacoxu Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CLA registered |
/assign @rajansandeep |
@MrHohn: GitHub didn't allow me to assign the following users: rajansandeep. Note that only kubernetes members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@MrHohn Yes, keeping them in different folders is doable. Is this something we need to prioritize for 1.10 or it can be for later releases? |
`coredns` is schedules DNS Pods and Service on the cluster, other pods in cluster | ||
can use the DNS Service’s IP to resolve DNS names. | ||
|
||
* [Administrators guide](https://coredns.io/2018/01/29/deploying-kubernetes-with-coredns-using-kubeadm/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This guide applies to installing CoreDNS via kubeadm and doesn't apply here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rajansandeep i agree.
also given the ongoing transition to CoreDNS the above paragraph would be misleading for the next release. i would Close this PR, until we have settled.
@rajansandeep No worries, seems fine to do that for later releases. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale hello, how do you want to proceed with this PR? @pacoxu |
@pacoxu also please sign the CLA. |
FYI, From https://kubernetes.io/docs/concepts/cluster-administration/addons/ :
I believe "here" above refers to the addons docs page itself, not the deprecated cluster/addons directory. IMO, if the docs are wrong, they should be fixed.
i.e. the reciprocal of the message in the docs. |
@chrisohaver hm, i don't know if the docs are wrong in this case. this particular PR might not get any further updates from the original author. |
I say close it. Per my understanding this addons directory is supposed to be deprecated (as of 10 months ago), and is also titled "Legacy Addons". |
ok /close |
What this PR does / why we need it:
No readme for coredns, only some for kube-dns
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
add some links and descriptions like kube-dns
Release note: