Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.7] subpath fixes #61047

Merged
merged 3 commits into from
Mar 12, 2018
Merged

[1.7] subpath fixes #61047

merged 3 commits into from
Mar 12, 2018

Commits on Mar 5, 2018

  1. Lock subPath volumes 

    Users must not be allowed to step outside the volume with subPath.
Therefore the final subPath directory must be "locked" somehow
and checked if it's inside volume.

On Windows, we lock the directories. On Linux, we bind-mount the final
subPath into /var/lib/kubelet/pods/<uid>/volume-subpaths/<container name>/<subPathName>,
it can't be changed to symlink user once it's bind-mounted.
    @jsafrane
    jsafrane committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    975d0a4 View commit details
    Browse the repository at this point in the history

  2. Add subpath e2e tests

    @jsafrane
    jsafrane committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    6b7688c View commit details
    Browse the repository at this point in the history

  3. Add feature gate for subpath

    @jsafrane
    jsafrane committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    a3a1714 View commit details
    Browse the repository at this point in the history