New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add udev to hyperkube and bump versions #61357

Merged
merged 1 commit into from Mar 28, 2018

Conversation

@rphillips
Member

rphillips commented Mar 19, 2018

What this PR does / why we need it: Adds udev to the hyperkube to fix GCE and OpenStack volume mounts.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #61356
Fixes #43515
Fixes coreos/bugs#2385

Special notes for your reviewer:

/cc @kubernetes/sig-node-bugs @kubernetes/sig-node-pr-reviews
/cc @ixdy

Release note:

Add ipset and udevadm to the hyperkube base image.
@rphillips

This comment has been minimized.

Member

rphillips commented Mar 19, 2018

/cc @lavalamp

@k8s-ci-robot k8s-ci-robot requested a review from lavalamp Mar 19, 2018

@rphillips

This comment has been minimized.

Member

rphillips commented Mar 20, 2018

@ixdy

This comment has been minimized.

Member

ixdy commented Mar 21, 2018

lgtm, I'll work on getting this built/pushed tomorrow.

do we have any e2e testing around hyperkube? finding all of these issues through bug reports is getting kinda old...

@dims

This comment has been minimized.

Member

dims commented Mar 21, 2018

@ixdy we have (ci|pull)-kubernetes-local-e2e jobs that use hyperkube (DIND environment). I am planning to reuse that harness (kubetest+local-up-cluster) to test OpenStack as well (under OpenLab https://openlabtesting.org/) and post results back to our dashboards. @hogepodge @codebauss @kiwik are all going to be involved in this effort. Another angle to this is to find/add e2e tests that are specific to cloud providers (same tests against multiple providers) as part of the cloud provider wg effort too. There are a few of us interested in that.

@ixdy

This comment has been minimized.

Member

ixdy commented Mar 21, 2018

/assign

@ixdy

images pushed. please update Bazel WORKSPACE dependency, and then this LGTM.

@@ -70,7 +70,7 @@ docker_pull(
digest = "sha256:d83594ecd85345144584523e7fa5388467edf5d2dfa30d0a1bcbf184cddf4a7b",

This comment has been minimized.

@ixdy

ixdy Mar 21, 2018

Member

please update this to sha256:cc782ed16599000ca4c85d47ec6264753747ae1e77520894dca84b104a7621e2

@rphillips

This comment has been minimized.

Member

rphillips commented Mar 23, 2018

@ixdy thanks! pushed the updated hash

@ixdy

This comment has been minimized.

Member

ixdy commented Mar 23, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 23, 2018

@ixdy

This comment has been minimized.

Member

ixdy commented Mar 23, 2018

/assign @mikedanese

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Mar 28, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ixdy

This comment has been minimized.

Member

ixdy commented Mar 28, 2018

not sure why the CLA bot is suddenly unhappy. did you rebase and change your email or something?

@rphillips

This comment has been minimized.

Member

rphillips commented Mar 28, 2018

@ixdy sorry, migrated the CLA bot to my new red hat address. I rewrote the commit. Should be good to go.

@ixdy

This comment has been minimized.

Member

ixdy commented Mar 28, 2018

/lgtm

@mikedanese

This comment has been minimized.

Member

mikedanese commented Mar 28, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Mar 28, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, mikedanese, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -22,7 +22,7 @@ ARCH?=amd64
OUT_DIR?=_output
HYPERKUBE_BIN?=$(OUT_DIR)/dockerized/bin/linux/$(ARCH)/hyperkube
BASEIMAGE=k8s.gcr.io/debian-hyperkube-base-$(ARCH):0.8

This comment has been minimized.

@ixdy

ixdy Mar 28, 2018

Member

what happened to 0.9?

This comment has been minimized.

@ixdy
@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 28, 2018

Automatic merge from submit-queue (batch tested with PRs 61848, 61188, 56363, 61357, 61838). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit ee99895 into kubernetes:master Mar 28, 2018

14 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation rphillips authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@rphillips

This comment has been minimized.

Member

rphillips commented Mar 28, 2018

Got a cherry pick up for 1.10: #61861

@ixdy

This comment has been minimized.

Member

ixdy commented Mar 28, 2018

/release-note

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Mar 28, 2018

@ixdy: the /release-note and /release-note-action-required commands have been deprecated.
Please edit the release-note block in the PR body text to include the release note. If the release note requires additional action include the string action required in the release note. For example:

```release-note
Some release note with action required.
```

In response to this:

/release-note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ixdy

This comment has been minimized.

Member

ixdy commented Mar 28, 2018

it occurs to me that a release note is probably a good idea?

@ixdy

This comment has been minimized.

Member

ixdy commented Mar 28, 2018

I apparently don't understand how to use the release note plugin anymore, though.

@rphillips

This comment has been minimized.

Member

rphillips commented Mar 28, 2018

@ixdy I updated the release note in the PR... I am not sure if I have to do anything, since it was after the merge.

k8s-merge-robot added a commit that referenced this pull request Apr 4, 2018

Merge pull request #61861 from rphillips/automated-cherry-pick-of-#61357
-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #61357: add udev to hyperkube and bump versions

Cherry pick of #61357 on release-1.10.

#61357: add udev to hyperkube and bump versions

k8s-merge-robot added a commit that referenced this pull request May 10, 2018

Merge pull request #63020 from rphillips/automated-cherry-pick-of-#61357
-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #61357: add udev to hyperkube and bump versions

Cherry pick of #61357 on release-1.9.

#61357: add udev to hyperkube and bump versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment