Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add udev to hyperkube and bump versions #61357

Merged
merged 1 commit into from
Mar 28, 2018
Merged

add udev to hyperkube and bump versions #61357

merged 1 commit into from
Mar 28, 2018

Conversation

rphillips
Copy link
Member

@rphillips rphillips commented Mar 19, 2018 •
edited
Loading

What this PR does / why we need it: Adds udev to the hyperkube to fix GCE and OpenStack volume mounts.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #61356
Fixes #43515
Fixes coreos/bugs#2385

Special notes for your reviewer:

/cc @kubernetes/sig-node-bugs @kubernetes/sig-node-pr-reviews
/cc @ixdy

Release note:

Add ipset and udevadm to the hyperkube base image.

@k8s-ci-robot k8s-ci-robot requested a review from ixdy March 19, 2018 15:14
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2018
@rphillips
Copy link
Member Author

/cc @lavalamp

@rphillips
Copy link
Member Author

cc @kubernetes/sig-storage-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Mar 20, 2018
@ixdy
Copy link
Member

ixdy commented Mar 21, 2018

lgtm, I'll work on getting this built/pushed tomorrow.

do we have any e2e testing around hyperkube? finding all of these issues through bug reports is getting kinda old...

@dims
Copy link
Member

dims commented Mar 21, 2018

@ixdy we have (ci|pull)-kubernetes-local-e2e jobs that use hyperkube (DIND environment). I am planning to reuse that harness (kubetest+local-up-cluster) to test OpenStack as well (under OpenLab https://openlabtesting.org/) and post results back to our dashboards. @hogepodge @codebauss @kiwik are all going to be involved in this effort. Another angle to this is to find/add e2e tests that are specific to cloud providers (same tests against multiple providers) as part of the cloud provider wg effort too. There are a few of us interested in that.

@ixdy
Copy link
Member

ixdy commented Mar 21, 2018

/assign

ixdy
ixdy reviewed Mar 21, 2018
View reviewed changes
Copy link
Member

@ixdy ixdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images pushed. please update Bazel WORKSPACE dependency, and then this LGTM.

build/root/WORKSPACE Outdated
@@ -70,7 +70,7 @@ docker_pull(
digest = "sha256:d83594ecd85345144584523e7fa5388467edf5d2dfa30d0a1bcbf184cddf4a7b",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update this to sha256:cc782ed16599000ca4c85d47ec6264753747ae1e77520894dca84b104a7621e2

@rphillips
Copy link
Member Author

@ixdy thanks! pushed the updated hash

@ixdy
Copy link
Member

ixdy commented Mar 23, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2018
@ixdy
Copy link
Member

ixdy commented Mar 23, 2018

/assign @mikedanese

@k8s-ci-robot k8s-ci-robot removed the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 28, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 28, 2018
@ixdy
Copy link
Member

ixdy commented Mar 28, 2018

not sure why the CLA bot is suddenly unhappy. did you rebase and change your email or something?

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 28, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 28, 2018
@rphillips
Copy link
Member Author

@ixdy sorry, migrated the CLA bot to my new red hat address. I rewrote the commit. Should be good to go.

This was referenced Mar 28, 2018
Closed
Closed
@ixdy
Copy link
Member

ixdy commented Mar 28, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2018
@ixdy ixdy mentioned this pull request Mar 28, 2018
Merged
@mikedanese
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, mikedanese, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2018
ixdy
ixdy reviewed Mar 28, 2018
View reviewed changes
cluster/images/hyperkube/Makefile
@@ -22,7 +22,7 @@ ARCH?=amd64
OUT_DIR?=_output
HYPERKUBE_BIN?=$(OUT_DIR)/dockerized/bin/linux/$(ARCH)/hyperkube

BASEIMAGE=k8s.gcr.io/debian-hyperkube-base-$(ARCH):0.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened to 0.9?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, oops: #57648 (comment)

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 61848, 61188, 56363, 61357, 61838). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit ee99895 into kubernetes:master Mar 28, 2018
@rphillips rphillips mentioned this pull request Mar 28, 2018
Merged
@rphillips
Copy link
Member Author

Got a cherry pick up for 1.10: #61861

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 28, 2018
@ixdy
Copy link
Member

ixdy commented Mar 28, 2018

/release-note

@k8s-ci-robot
Copy link
Contributor

@ixdy: the /release-note and /release-note-action-required commands have been deprecated.
Please edit the release-note block in the PR body text to include the release note. If the release note requires additional action include the string action required in the release note. For example:

```release-note
Some release note with action required.
```

In response to this:

/release-note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ixdy
Copy link
Member

ixdy commented Mar 28, 2018

it occurs to me that a release note is probably a good idea?

@ixdy
Copy link
Member

ixdy commented Mar 28, 2018

I apparently don't understand how to use the release note plugin anymore, though.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 28, 2018
@rphillips
Copy link
Member Author

@ixdy I updated the release note in the PR... I am not sure if I have to do anything, since it was after the merge.

k8s-github-robot pushed a commit that referenced this pull request Apr 4, 2018
Merge pull request #61861 from rphillips/automated-cherry-pick-of-#61…
ac3342b 
…357-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #61357: add udev to hyperkube and bump versions

Cherry pick of #61357 on release-1.10.

#61357: add udev to hyperkube and bump versions
@dims dims mentioned this pull request Apr 5, 2018
Closed
@rphillips rphillips mentioned this pull request Apr 23, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request May 10, 2018
Merge pull request #63020 from rphillips/automated-cherry-pick-of-#61…
9a0c056 
…357-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #61357: add udev to hyperkube and bump versions

Cherry pick of #61357 on release-1.9.

#61357: add udev to hyperkube and bump versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixdy ixdy ixdy left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@mikedanese mikedanese

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
6 participants
@rphillips @ixdy @dims @k8s-ci-robot @mikedanese @k8s-github-robot