Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use inline func to ensure unlock is executed #61644

Merged
merged 1 commit into from Mar 27, 2018
Merged

Use inline func to ensure unlock is executed #61644

merged 1 commit into from Mar 27, 2018

Conversation

resouer
Copy link
Contributor

@resouer resouer commented Mar 25, 2018

What this PR does / why we need it:

Per discussion: #61621 (comment)

Special notes for your reviewer:

Ref: #58222

Release note:

Use inline func to ensure unlock is executed

@resouer resouer added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Mar 25, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2018
@resouer resouer requested review from bsalamat and removed request for jayunit100 and ravisantoshgudimetla March 25, 2018 18:56
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 25, 2018
@resouer
Copy link
Contributor Author

resouer commented Mar 25, 2018

cc @liggitt

@bsalamat
Copy link
Member

Thanks, Harry!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, resouer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 61644, 61624, 61743, 61019, 61287). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 20f76de into kubernetes:master Mar 27, 2018
@resouer resouer mentioned this pull request Apr 10, 2018
Closed
@misterikkit misterikkit mentioned this pull request Apr 26, 2018
Merged
@misterikkit misterikkit mentioned this pull request May 18, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request May 19, 2018
Merge pull request #64041 from misterikkit/automated-cherry-pick-of-#…
2bba012 
…61644-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #61644: Use inclien func to ensure unlock is executed

Cherry pick of #61644 on release-1.10.

#61644: Use inclien func to ensure unlock is executed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsalamat bsalamat Awaiting requested review from bsalamat

Assignees

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@resouer @bsalamat @k8s-ci-robot @k8s-github-robot