Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support overriding the --node-cidr-mask-size arg passed to kube-controller-manager #61705
@jstangroome thanks for your PR!
I fully agree that we extraArgs should override default arguments.
However I think that the solution you are proposing fixes this problem only for the mask size.
What do you think about a slightly different solution that before builds all the default arguments and only at the end of the function builds the command merging extraArgs (in other words, what about moving https://github.com/jstangroome/kubernetes/blob/438818f22932c08b86ebaa7de5c7c5db9d6d7d7c/cmd/kubeadm/app/phases/controlplane/manifests.go#L324 and L235 at the end of the function)?
@fabriziopandini: GitHub didn't allow me to request PR reviews from the following users: for, approval.
Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@fabriziopandini I'll look into what would be involved to fix the extra args handling for the other components installed by kubeadm.
Also, I'm not sure I understand how the GitHub Test failures correlate to my code changes. Any suggestions on how to investigate this?
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
@jstangroome: The following test failed, say