Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubeadm] Bump kube-dns to 1.14.9 #61918

Merged
merged 1 commit into from
Apr 6, 2018

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented Mar 29, 2018

What this PR does / why we need it:
Bump kube-dns to 1.14.9 for kubeadm. Ref #61908.

cc @rramkumar1

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #NONE

Special notes for your reviewer:

Release note:

Update kube-dns to Version 1.14.9 in kubeadm.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 29, 2018
@rramkumar1
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2018
@MrHohn
Copy link
Member Author

MrHohn commented Mar 29, 2018

/assign @timothysc

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2018
@MrHohn
Copy link
Member Author

MrHohn commented Mar 29, 2018

Sorry missed a test file. Updated.

@rramkumar1
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2018
@MrHohn
Copy link
Member Author

MrHohn commented Mar 30, 2018

/test pull-kubernetes-node-e2e

@xiangpengzhao
Copy link
Contributor

@MrHohn are you planning to cherry-pick this to 1.9 ?

@MrHohn
Copy link
Member Author

MrHohn commented Mar 30, 2018

are you planning to cherry-pick this to 1.9 ?

@xiangpengzhao Planning to cherrypick #61908, though not sure about the kubeadm one.

@rramkumar1
Copy link
Contributor

ping @timothysc

@xiangpengzhao
Copy link
Contributor

Planning to cherrypick #61908, though not sure about the kubeadm one.

If we cherry-pick this PR, it mostly probably will be merged to the next patch version of 1.9 series (i.e., 1.9.7). When users upgrade kubernetes 1.9.7 to 1.10.0, kube-dns will be downgraded (i.e., from 1.14.9 to 1.14.8). Not sure if this will cause some issue, but users might be confused.

@xiangpengzhao
Copy link
Contributor

/test pull-kubernetes-verify

@xiangpengzhao
Copy link
Contributor

/retest

@rramkumar1
Copy link
Contributor

@xiangpengzhao We would expect that users upgrade to the latest 1.10 patch release, not 1.10.0. If they follow this standard, then they will see no issues.

@xiangpengzhao
Copy link
Contributor

@rramkumar1 but the coming 1.10.1 may be released later than the coming 1.9.7, right? If so, users may still upgrade from 1.9.7 to 1.10.0

@rramkumar1
Copy link
Contributor

@xiangpengzhao I would assume 1.10.1 and 1.9.7 are released pretty much at the same time. Even if they weren't, I don't think someone would upgrade to 1.9.7 and then immediately to 1.10.1 without leaving time for 1.10.2 to be released. Anyways, we are cherry picking this change back to 1.9 since the new kube-dns contains critical bug fixes so it needs to get in.

@xiangpengzhao
Copy link
Contributor

@rramkumar1 agreed. I was also thinking of the case you mentioned. That's reasonable.

@krousey
Copy link
Contributor

krousey commented Apr 6, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krousey, MrHohn, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

@MrHohn: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce ce2d2c7 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 61918, 62180, 62198). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 3bba2d6 into kubernetes:master Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants