New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubeadm] Bump kube-dns to 1.14.9 #61918

Merged
merged 1 commit into from Apr 6, 2018

Conversation

Projects
None yet
7 participants
@MrHohn
Member

MrHohn commented Mar 29, 2018

What this PR does / why we need it:
Bump kube-dns to 1.14.9 for kubeadm. Ref #61908.

cc @rramkumar1

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #NONE

Special notes for your reviewer:

Release note:

Update kube-dns to Version 1.14.9 in kubeadm.
@rramkumar1

This comment has been minimized.

Member

rramkumar1 commented Mar 29, 2018

/lgtm

@MrHohn

This comment has been minimized.

Member

MrHohn commented Mar 29, 2018

/assign @timothysc

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 29, 2018

@MrHohn

This comment has been minimized.

Member

MrHohn commented Mar 29, 2018

Sorry missed a test file. Updated.

@rramkumar1

This comment has been minimized.

Member

rramkumar1 commented Mar 29, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 29, 2018

@MrHohn

This comment has been minimized.

Member

MrHohn commented Mar 30, 2018

/test pull-kubernetes-node-e2e

@xiangpengzhao

This comment has been minimized.

Member

xiangpengzhao commented Mar 30, 2018

@MrHohn are you planning to cherry-pick this to 1.9 ?

@MrHohn

This comment has been minimized.

Member

MrHohn commented Mar 30, 2018

are you planning to cherry-pick this to 1.9 ?

@xiangpengzhao Planning to cherrypick #61908, though not sure about the kubeadm one.

@rramkumar1

This comment has been minimized.

Member

rramkumar1 commented Apr 2, 2018

ping @timothysc

@xiangpengzhao

This comment has been minimized.

Member

xiangpengzhao commented Apr 3, 2018

Planning to cherrypick #61908, though not sure about the kubeadm one.

If we cherry-pick this PR, it mostly probably will be merged to the next patch version of 1.9 series (i.e., 1.9.7). When users upgrade kubernetes 1.9.7 to 1.10.0, kube-dns will be downgraded (i.e., from 1.14.9 to 1.14.8). Not sure if this will cause some issue, but users might be confused.

@xiangpengzhao

This comment has been minimized.

Member

xiangpengzhao commented Apr 3, 2018

/test pull-kubernetes-verify

@xiangpengzhao

This comment has been minimized.

Member

xiangpengzhao commented Apr 3, 2018

/retest

@rramkumar1

This comment has been minimized.

Member

rramkumar1 commented Apr 3, 2018

@xiangpengzhao We would expect that users upgrade to the latest 1.10 patch release, not 1.10.0. If they follow this standard, then they will see no issues.

@xiangpengzhao

This comment has been minimized.

Member

xiangpengzhao commented Apr 4, 2018

@rramkumar1 but the coming 1.10.1 may be released later than the coming 1.9.7, right? If so, users may still upgrade from 1.9.7 to 1.10.0

@rramkumar1

This comment has been minimized.

Member

rramkumar1 commented Apr 4, 2018

@xiangpengzhao I would assume 1.10.1 and 1.9.7 are released pretty much at the same time. Even if they weren't, I don't think someone would upgrade to 1.9.7 and then immediately to 1.10.1 without leaving time for 1.10.2 to be released. Anyways, we are cherry picking this change back to 1.9 since the new kube-dns contains critical bug fixes so it needs to get in.

@xiangpengzhao

This comment has been minimized.

Member

xiangpengzhao commented Apr 4, 2018

@rramkumar1 agreed. I was also thinking of the case you mentioned. That's reasonable.

@krousey

This comment has been minimized.

Member

krousey commented Apr 6, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Apr 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krousey, MrHohn, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 6, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Apr 6, 2018

@MrHohn: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce ce2d2c7 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 6, 2018

Automatic merge from submit-queue (batch tested with PRs 61918, 62180, 62198). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 3bba2d6 into kubernetes:master Apr 6, 2018

12 of 14 checks passed

pull-kubernetes-e2e-gce Job failed.
Details
Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation MrHohn authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment