Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GLBC manifest to v1.0.1 #62075

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Update GLBC manifest to v1.0.1 #62075

merged 1 commit into from
Apr 4, 2018

Conversation

nicksardo
Copy link
Contributor

@nicksardo nicksardo commented Apr 3, 2018 •
edited
Loading

Release note:

GCE: Updates GLBC version to 1.0.1 which includes a fix which prevents multi-cluster ingress objects from creating full load balancers.

/assign @bowei @nikhiljindal
cc @csbell @rramkumar1 @freehan @MrHohn

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 3, 2018
@nicksardo
Copy link
Contributor Author

/uncc jszczepkowski vishh
/cc bowei

@k8s-ci-robot k8s-ci-robot requested review from bowei and removed request for vishh and jszczepkowski April 3, 2018 18:49
nikhiljindal
nikhiljindal reviewed Apr 3, 2018
View reviewed changes
cluster/gce/manifests/glbc.manifest
kubernetes.io/name: "GLBC"
spec:
terminationGracePeriodSeconds: 600
hostNetwork: true
containers:
- image: k8s.gcr.io/ingress-gce-glbc-amd64:1.0.0
- image: k8s.gcr.io/ingress-gce-glbc-amd64:v1.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we have added a "v" prefix. Want to confirm thats intentional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed in person thats intentional

@nikhiljindal
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2018
@bowei
Copy link
Member

bowei commented Apr 3, 2018

/approve no-issue

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, nicksardo, nikhiljindal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2018
@nicksardo
Copy link
Contributor Author

/test pull-kubernetes-integration

This was referenced Apr 3, 2018
Merged
Merged
@nicksardo nicksardo mentioned this pull request Apr 3, 2018
Merged
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 61806, 61508, 62075, 62079, 62052). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit ba1768b into kubernetes:master Apr 4, 2018
k8s-github-robot pushed a commit that referenced this pull request Apr 4, 2018
Merge pull request #62079 from rramkumar1/patch-6
6e3aa7a 
Automatic merge from submit-queue (batch tested with PRs 61806, 61508, 62075, 62079, 62052). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update image for ingress downgrade test

**What this PR does / why we need it**:
Ref: #62075

**Release note**:

```release-note
None
```

/assign @bowei
k8s-github-robot pushed a commit that referenced this pull request Apr 6, 2018
Merge pull request #62081 from nicksardo/automated-cherry-pick-of-#62…
d063f96 
…075-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #62075: Update GLBC manifest to v1.0.1

Cherry pick of #62075 on release-1.10.

#62075: Update GLBC manifest to v1.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhiljindal nikhiljindal nikhiljindal left review comments

@bowei bowei Awaiting requested review from bowei

Assignees

@bowei bowei

@nikhiljindal nikhiljindal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nicksardo @nikhiljindal @bowei @k8s-ci-robot @k8s-github-robot