Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a more ideal example for scheduler extender policy. #62186

Closed
wants to merge 1 commit into from

Conversation

rohitagarwal003
Copy link
Member

We now use default predicates/priorities if they are unspecified in the policy
config (#59363).

The other example in ./scheduler-policy-config.json shows how to use priorities
and predicates.

Let's use this example to show how to use extenders. When you are using
extenders you don't necessarily want to mess with priorities and predicates
(#45188).

NONE

We now use default predicates/priorities if they are unspecified in the policy
config (kubernetes#59363).

The other example in ./scheduler-policy-config.json shows how to use priorities
and predicates.

Let's use this example to show how to use extenders. When you are using
extenders you don't necessarily want to mess with priorities and predicates
(kubernetes#45188).
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. labels Apr 6, 2018
@k8s-ci-robot
Copy link
Contributor

@mindprince: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[examples/ has moved to https://github.com/kubernetes/examples/]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 6, 2018
@rohitagarwal003
Copy link
Member Author

/assign @yguo0905 @bsalamat

@rohitagarwal003
Copy link
Member Author

/retest

@yguo0905
Copy link
Contributor

yguo0905 commented Apr 6, 2018

/lgtm
Thanks for fixing the example!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2018
@rohitagarwal003
Copy link
Member Author

/assign @thockin

@bsalamat
Copy link
Member

bsalamat commented Apr 6, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bsalamat, mindprince, yguo0905
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: thockin

Assign the PR to them by writing /assign @thockin in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thockin
Copy link
Member

thockin commented Apr 9, 2018

kubernetes/kubernetes/examples is going away - you really want to fix https://github.com/kubernetes/examples/blob/master/scheduler/scheduler-policy-config-with-extender.json

@thockin
Copy link
Member

thockin commented Apr 9, 2018

closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants