Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Removed no-empty validation of nodeSelectorTerm.matchExpressions. #62448
Signed-off-by: Da K. Ma email@example.com
Which issue(s) this PR fixes (optional, in
changed the title
WIP: Removed no-empty validation of nodeSelectorTerm.matchExpressions.
Apr 14, 2018
Nit on removing code rather than commenting it out… I don't anticipate this validation returning.
LGTM otherwise, this makes the code behave as documented, and be forward compatible with field selector additions. A second from @kubernetes/api-reviewers would also be good.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
[MILESTONENOTIFIER] Milestone Pull Request Needs Approval
Action required: This pull request must have the
Pull Request Labels
1 similar comment
Apr 17, 2018
13 of 15 checks passed
@k82cn: The following test failed, say