Removed no-empty validation of nodeSelectorTerm.matchExpressions. #62448

k82cn · 2018-04-12T08:24:48Z

Signed-off-by: Da K. Ma klaus1982.cn@gmail.com

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
part of #62002

Release note:

Pod affinity `nodeSelectorTerm.matchExpressions` may now be empty, and works as previously documented: nil or empty `matchExpressions` matches no objects in scheduler.

k82cn · 2018-04-12T14:15:21Z

/retest

k82cn · 2018-04-14T00:28:09Z

/cc @liggitt

liggitt · 2018-04-14T01:02:59Z

pkg/apis/core/validation/validation.go

+	//	if len(term.MatchExpressions) == 0 {
+	//		return append(allErrs, field.Required(fldPath.Child("matchExpressions"), "must have at least one node selector requirement"))
+	//	}
+


Remove rather than comment?

liggitt · 2018-04-14T01:06:42Z

Nit on removing code rather than commenting it out… I don't anticipate this validation returning.

LGTM otherwise, this makes the code behave as documented, and be forward compatible with field selector additions. A second from @kubernetes/api-reviewers would also be good.

Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>

k82cn · 2018-04-14T04:41:54Z

/retest

liggitt · 2018-04-14T14:12:53Z

cc @kubernetes/sig-scheduling-api-reviews

k82cn · 2018-04-17T01:48:28Z

ping @kubernetes/api-reviewers for comments, some other feature dependent on that PR :)

liggitt · 2018-04-17T11:53:33Z

/lgtm

k8s-ci-robot · 2018-04-17T11:53:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/apis/core/OWNERS~~ [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k82cn · 2018-04-17T13:54:43Z

/retest

k8s-github-robot · 2018-04-17T14:27:59Z

[MILESTONENOTIFIER] Milestone Pull Request Needs Approval

@k82cn @liggitt @kubernetes/sig-scheduling-misc

Action required: This pull request must have the status/approved-for-milestone label applied by a SIG maintainer. If the label is not applied within 4 days, the pull request will be moved out of the v1.10 milestone.

Pull Request Labels

sig/scheduling: Pull Request will be escalated to these SIGs if needed.
priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
kind/bug: Fixes a bug discovered during the current release.

Help

liggitt · 2018-04-17T15:04:12Z

/retest

fejta-bot · 2018-04-17T17:40:50Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot · 2018-04-17T20:49:52Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

k8s-github-robot · 2018-04-17T22:15:09Z

/test all [submit-queue is verifying that this PR is safe to merge]

k82cn · 2018-04-17T23:29:01Z

/retest

k8s-github-robot · 2018-04-17T23:31:14Z

Automatic merge from submit-queue (batch tested with PRs 62448, 59317, 59947, 62418, 62352). If you want to cherry-pick this change to another branch, please follow the instructions here.

liggitt · 2018-04-18T00:04:11Z

Thanks. Can you pick this to 1.10 as well?

k8s-ci-robot · 2018-04-18T00:41:51Z

@k82cn: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-gce	`d8e6dbf`	link	`/test pull-kubernetes-e2e-gce`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

…upstream-release-1.10 Automatic merge from submit-queue. Automated cherry pick of #62448: Removed no-empty validation of nodeSelectorTerm.matchExpressions. Cherry pick of #62448 on release-1.10. #62448: Removed no-empty validation of nodeSelectorTerm.matchExpressions.

Automatic merge from submit-queue (batch tested with PRs 62982, 63075, 63067, 62877, 63141). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Removed e2e test on empty NodeAffinity. Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com> **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes kubernetes#63027 **Special notes for your reviewer**: In kubernetes#62448, we removed the validation on empty `nodeAffinity` which is already handled in scheduler: select no objects. **Release note**: ```release-note None ```

k8s-ci-robot requested review from gmarek and nikhiljindal April 12, 2018 08:24

k82cn mentioned this pull request Apr 14, 2018

Added MatchFields to NodeSelectorTerm #62002

Merged

k8s-ci-robot requested a review from liggitt April 14, 2018 00:28

k82cn changed the title ~~WIP: Removed no-empty validation of nodeSelectorTerm.matchExpressions.~~ Removed no-empty validation of nodeSelectorTerm.matchExpressions. Apr 14, 2018

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2018

liggitt reviewed Apr 14, 2018

View reviewed changes

Removed no-empty validation of nodeSelectorTerm.matchExpressions.

d8e6dbf

Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>

k82cn force-pushed the k8s_62002 branch from 77d173b to d8e6dbf Compare April 14, 2018 01:23

liggitt added the cherrypick-candidate label Apr 14, 2018

liggitt added this to the v1.10 milestone Apr 14, 2018

k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Apr 14, 2018

k8s-github-robot added the milestone/incomplete-labels label Apr 14, 2018

liggitt added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 14, 2018

k8s-github-robot added milestone/needs-approval and removed milestone/incomplete-labels labels Apr 14, 2018

k8s-ci-robot assigned liggitt Apr 17, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2018

k8s-github-robot merged commit 084715a into kubernetes:master Apr 17, 2018

k82cn deleted the k8s_62002 branch April 17, 2018 23:31

k82cn mentioned this pull request Apr 18, 2018

Automated cherry pick of #62448: Removed no-empty validation of nodeSelectorTerm.matchExpressions. #62759

Merged

This was referenced Apr 24, 2018

Failing Test: [sig-scheduling] SchedulerPredicates [Serial] validates that a pod with an invalid NodeAffinity is rejected #63027

Closed

Removed e2e test on empty NodeAffinity. #63067

Merged

This was referenced May 14, 2018

gke-staging-1-9-1-10-upgrade-master: FAILING [sig-scheduling] SchedulerPredicates [Serial] validates that a pod with an invalid NodeAffinity is rejected #63815

Closed

Removed e2e test on empty NodeAffinity. #63816

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed no-empty validation of nodeSelectorTerm.matchExpressions. #62448

Removed no-empty validation of nodeSelectorTerm.matchExpressions. #62448

k82cn commented Apr 12, 2018 •

edited by liggitt

Loading

k82cn commented Apr 12, 2018

k82cn commented Apr 14, 2018

liggitt Apr 14, 2018

liggitt commented Apr 14, 2018

k82cn commented Apr 14, 2018

liggitt commented Apr 14, 2018

k82cn commented Apr 17, 2018

liggitt commented Apr 17, 2018

k8s-ci-robot commented Apr 17, 2018

k82cn commented Apr 17, 2018

k8s-github-robot commented Apr 17, 2018

liggitt commented Apr 17, 2018

fejta-bot commented Apr 17, 2018

fejta-bot commented Apr 17, 2018

k8s-github-robot commented Apr 17, 2018

k82cn commented Apr 17, 2018

k8s-github-robot commented Apr 17, 2018

liggitt commented Apr 18, 2018

k8s-ci-robot commented Apr 18, 2018

Removed no-empty validation of nodeSelectorTerm.matchExpressions. #62448

Removed no-empty validation of nodeSelectorTerm.matchExpressions. #62448

Conversation

k82cn commented Apr 12, 2018 • edited by liggitt Loading

k82cn commented Apr 12, 2018

k82cn commented Apr 14, 2018

liggitt Apr 14, 2018

Choose a reason for hiding this comment

liggitt commented Apr 14, 2018

k82cn commented Apr 14, 2018

liggitt commented Apr 14, 2018

k82cn commented Apr 17, 2018

liggitt commented Apr 17, 2018

k8s-ci-robot commented Apr 17, 2018

k82cn commented Apr 17, 2018

k8s-github-robot commented Apr 17, 2018

liggitt commented Apr 17, 2018

fejta-bot commented Apr 17, 2018

fejta-bot commented Apr 17, 2018

k8s-github-robot commented Apr 17, 2018

k82cn commented Apr 17, 2018

k8s-github-robot commented Apr 17, 2018

liggitt commented Apr 18, 2018

k8s-ci-robot commented Apr 18, 2018

k82cn commented Apr 12, 2018 •

edited by liggitt

Loading